-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar-resizer: change $:/themes/...
tiddlers
#8663
Draft
BurningTreeC
wants to merge
197
commits into
TiddlyWiki:master
Choose a base branch
from
BurningTreeC:sidebar-resizer-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
197 commits
Select commit
Hold shift + click to select a range
1e0d4b8
Create sidebar-resizer.tid
BurningTreeC be6510b
updates
BurningTreeC 7fbbb4e
updates
BurningTreeC 22b33e6
updates
BurningTreeC 035c23e
updates
BurningTreeC f547be6
remove some unnecessary calculations
BurningTreeC 315e543
clean up stylesheet
BurningTreeC 445547d
for now, in fixed-fluid mode keep story and tiddler fixed width
BurningTreeC bc9706d
wip: fixed-fluid mode, change storyleft. + more calculations
BurningTreeC 02498a1
no high z-index on first eventcatcher
BurningTreeC dd5af9f
cleanup pointermove actions
BurningTreeC ea7da2b
more calculations
BurningTreeC 6b98a2d
update base stylesheet
BurningTreeC 01c945e
fix filters
BurningTreeC 6fd3432
updates
BurningTreeC 667e173
updates
BurningTreeC ca32bed
add fallbacks
BurningTreeC 40a89fc
add ctrl modifier drag for fixed-fluid mode that changes behavior
BurningTreeC b7d542e
updates
BurningTreeC c31a51f
cleanup
BurningTreeC 61cb65f
updates
BurningTreeC 6176f3a
simplify pointermove actions and calculations
BurningTreeC fb47dfd
different behavior for ctrl-dragging
BurningTreeC 3c4d7c5
fix problem with double px suffixes
BurningTreeC 126c216
delete config tiddler
BurningTreeC e84dfa4
position the resizer correctly in fixed-fluid
BurningTreeC 5d22139
make ctrl in fixed-fluid mode work like I intended
BurningTreeC c149989
make it work with em too
BurningTreeC f823a81
add themetweaks configs for sidebarminwidth and storyminwidth
BurningTreeC 8f9cbe9
store the ctrl modifier
BurningTreeC 807397c
add css limits in base stylesheet
BurningTreeC 9bae7ca
add hint in ThemeTweaks for now, make shift jump out of ctrl mode
BurningTreeC 4a746bf
set storyminwidth to 168px
BurningTreeC dbda2c8
cleanup
BurningTreeC 76d8c97
cleanup
BurningTreeC e5a2f37
updates, fixed-fluid
BurningTreeC 8360871
make tiddlerwidth percentages work
BurningTreeC da76a2f
add support for centralised for testing
BurningTreeC da23268
some small adjustments
BurningTreeC 8cefe1b
update for negative tiddler width
BurningTreeC fd615da
small update for centralised
BurningTreeC 25d4bd3
centralised adjustments
BurningTreeC 03a860f
conditionally show themetweaks metrics
BurningTreeC 910cffb
further adjustments
BurningTreeC a69d324
fix edgecase in centralised theme
BurningTreeC 22a4099
add some newlines at end of file
BurningTreeC fbf299b
fix edgecase in centralised theme fix
BurningTreeC c092912
missing closing bla
BurningTreeC 8637f16
update for clamped edgecases
BurningTreeC ca68786
update for clamped edgecases
BurningTreeC 6122c5b
tiddlerwidth is not clamped
BurningTreeC 0a3dd8b
tiddlerwidth is clamped in certain cases
BurningTreeC 8ad8496
tiddlerwidth min-width 0px makes sense
BurningTreeC c2ae885
fix another edgecase
BurningTreeC b33be06
more clamping
BurningTreeC 1d9a4c4
wip: make it work cross-theme (tight)
BurningTreeC 7c2e05e
make it respect the metrics of the current theme
BurningTreeC 7fc2239
get metrics by currently selected theme
BurningTreeC 0b48093
add some ThemeTweak language strings
BurningTreeC ea1ff26
make ThemeTweaks flexible based on currently selected theme
BurningTreeC 247f5eb
remove centralised language themetweaks
BurningTreeC f171a0b
fix themetweaks
BurningTreeC e96ff3f
correctly check if theme tiddler exists
BurningTreeC 11cb571
fix padding in centralised theme
BurningTreeC 23f8af3
fix resizer positioning
BurningTreeC db683e2
add hint for story-right-padding
BurningTreeC d399543
update tight theme padding
BurningTreeC 054d630
update vanilla base
BurningTreeC 48ed5dc
update vanilla base
BurningTreeC 7dde829
update tight base
BurningTreeC a3a5d65
fix
BurningTreeC 902a91e
add refresh throttling to config tiddlers
BurningTreeC 4d60f91
adjustments for html dir=rtl
BurningTreeC b9c70fe
more adjustments for html dir=rtl
BurningTreeC e217b1a
add docs
BurningTreeC a94d496
make showing the sidebar resizer configurable and hide by default
BurningTreeC 0bf2349
more adjustments for html dir=rtl + show sidebar on the left (configu…
BurningTreeC 140d435
further adjustments for rtl and sidebar left
BurningTreeC fa42e6c
fixes for sidebar hidden
BurningTreeC 4d86493
remove unused html-direction variable
BurningTreeC 89623dd
small css fix for tight theme
BurningTreeC dd0c3f9
Merge branch 'TiddlyWiki:master' into sidebar-resizer-config
BurningTreeC de653df
cleanup
BurningTreeC 0c132c9
make it more generic
BurningTreeC b5a5bf8
more generic adjustments
BurningTreeC 70b759c
make it more generic
BurningTreeC 4f9a2fa
make it more generic
BurningTreeC 2794413
make everything even more generic
BurningTreeC ae28506
make everything even more generic
BurningTreeC 743b465
make everything even more generic
BurningTreeC d268fd7
fix detection of dependents
BurningTreeC 707db27
update ThemeTweaks/Hint
BurningTreeC 3e502b7
make dependents detection more stable
BurningTreeC 5f4484e
make dependents detection more reliable
BurningTreeC 25013e9
update ThemeTweaks
BurningTreeC 0c5de55
add an example theme that builds on three different themes
BurningTreeC 3021154
updates for sidebarbreakpoint
BurningTreeC b888ac2
updates
BurningTreeC a1b356e
update menubar plugin
BurningTreeC 9b4e961
move sidebar-resizer ui into dedicated PageTemplate
BurningTreeC 49105f1
rename sidebar-resizer PageTemplate
BurningTreeC fcbdf11
pick a theme if none is set
BurningTreeC 5727ddd
pick a theme if none is set
BurningTreeC 1d5e76c
make use of get.current.theme
BurningTreeC f7d83b8
different em conversion for inside tiddlerbody and outside
BurningTreeC 1b5889f
only use sidebarresizer if theme explicitly sets option to show
BurningTreeC adc3007
add optional variables for sidebar-resizer metrics definable as funct…
BurningTreeC dfa9a0a
revert overflow-fix on .tc-tab-content.tc-vertical - maybe a differen…
BurningTreeC c617e28
add dblclick below 500ms to hide sidebar
BurningTreeC 30b4a4f
thank you pmario, cleaned up global functions
BurningTreeC 801396b
add convert.to.pixels.locally function that uses conver.to.pixels glo…
BurningTreeC 2e2914a
fix false use of get.theme.metric for storypaddingleft and storypaddi…
BurningTreeC 32894e7
make two functions more readable
BurningTreeC d4a94d4
more refactoring for readability
BurningTreeC a35b9a5
use get.theme.option sidebarposition instead of vanilla option directly
BurningTreeC 338a3d1
start making it possible to use this universally
BurningTreeC f63b1ed
wip make it universally usable
BurningTreeC e61dd82
add two-cell-slider procedure
BurningTreeC 530500e
add one-cell-slider procedure and use it for editor and preview
BurningTreeC 62333ce
small update, todo for all variables
BurningTreeC a253b6e
update sliderWidth between editor and preview
BurningTreeC 0688142
make editor - preview slider stable
BurningTreeC 669fd60
adjust left margin of tiddler preview
BurningTreeC bb673fc
make minwidths configurable
BurningTreeC d92e4d9
updates
BurningTreeC a53f839
cleanup
BurningTreeC ce832d8
use is tiddler
BurningTreeC babed80
updates
BurningTreeC 187f34d
updates
BurningTreeC eb06c37
replace more not-is-missing with is-tiddler
BurningTreeC ce244fe
update minwidths
BurningTreeC 324ead8
updates
BurningTreeC e167eef
updates
BurningTreeC 843f043
updates
BurningTreeC f6a7e41
updates
BurningTreeC 6b31a11
adjustments for html dir=rtl
BurningTreeC bbcfba7
updates
BurningTreeC d652f17
fixes
BurningTreeC 340375d
make fluid-fixed and fixed-fluid visually the same (storyminwidth and…
BurningTreeC 9b1d746
make fixed-fluid mode respect paddingleft and paddingright and add ad…
BurningTreeC 6e2c39a
margin-left margin-right -2px for tc-editor-toolbar is enough
BurningTreeC e1d0f1b
adjustment for sidebar left and dir=rtl
BurningTreeC dc6031b
adjustment for sidebar left + storyleft
BurningTreeC 3b9b535
more adjustments for html dir=rtl
BurningTreeC a609ffe
big WIP: keeping the values in fixed-fluid mode fixed-fluid
BurningTreeC 3c23411
make minwidth in fluid-fixed same as in fixed-fluid
BurningTreeC 1b6953d
update margin-right of fluid-fixed story-river
BurningTreeC c1e4019
test with 42px
BurningTreeC dca7367
big overhaul. fixed-fluid adjustments, simplifying stylesheets, corre…
BurningTreeC 6aaea70
correct margin-left of story-river when sidebar is on the left
BurningTreeC fe31cd3
take into account that story-padding left and story-padding right cha…
BurningTreeC b9cc273
remove obsolete sidebarPadding value + update wording of StoryMinWidt…
BurningTreeC fc19bf8
change wordings of control-panel hints
BurningTreeC 5b66e0b
fix tiddler editor not shown on small screens
BurningTreeC 91af04d
fix tiddler editor resizer not shown on small screens
BurningTreeC 936df82
move styles for editor and preview into stylesheet
BurningTreeC 0664df8
style update to make preview slider move
BurningTreeC 6682c46
small update for text editors that create divs instead of iframes
BurningTreeC 8482150
convert indentation to tabs in body-editor EditTemplate
BurningTreeC 499a052
add display:none !important; because codemirror adds inline style dis…
BurningTreeC 275495e
correct margins of story-river when sidebar is hidden
BurningTreeC 0547143
fix reversed sliding of editor preview when sidebar is on the left
BurningTreeC 28dedda
make margin-bottom of texteditor same as margin-bottom of preview
BurningTreeC 27cf77a
make sandbox iframe in tiddler preview full width
BurningTreeC 1d92db2
cleanup
BurningTreeC 279146d
Merge branch 'TiddlyWiki:master' into sidebar-resizer-config
BurningTreeC 05cecd5
fix fixed-fluid resizer position
BurningTreeC 9f4d468
fix fixed-fluid resizer position
BurningTreeC 9e68de1
fix fixed-fluid resizer position cross-browser: no abs() but sqrt() a…
BurningTreeC c5e9054
fix fixed-fluid resizer position cross-browser: no abs(), no sqrt() a…
BurningTreeC eb24314
add tiddlerminwidth edge-case handling
BurningTreeC c03c3f2
fix storyWidthOverlap and storyRightOverlap
BurningTreeC 2bb115d
clamp tiddlerwidth between minimum tiddlerwidth
BurningTreeC 35c510e
fix another edge-case
BurningTreeC 796c88f
fix another edge-case
BurningTreeC 341c83e
fix another edge-case + fix sidebar-resizer positioning
BurningTreeC fa517d9
remove two unused variables
BurningTreeC 3c56f68
add metrics for slideropacity and slideropacityhover + theme tweaks s…
BurningTreeC 973a604
Merge branch 'TiddlyWiki:master' into sidebar-resizer-config
BurningTreeC b0cced5
use slideropacity metrics everywhere
BurningTreeC f50029b
merge
BurningTreeC 6da0beb
dont show metrics of fixed-fluid in fluid-fixed mode and vice versa +…
BurningTreeC b137309
don't let storyminwidth be negative
BurningTreeC faa8ceb
follow pmario's suggestions
BurningTreeC 0c0897f
more cleanup like pmario suggests
BurningTreeC 545e2aa
fix preview icon and preview slider
BurningTreeC 7522109
use get.edit-preview-state
BurningTreeC 3261818
fix sidebar slider not moving anymore
BurningTreeC 2e68b6f
rename tc-sidebar-resizer to tc-slider
BurningTreeC 40489a2
fix editor-preview button not focusing editor, two-cell-slider experi…
BurningTreeC 7a299bc
make editor not redraw
BurningTreeC 6876d7f
add touchmove for testing
BurningTreeC b7bec59
fix problem that resizing redraw the editor and preview
BurningTreeC fc83962
Merge branch 'TiddlyWiki:master' into sidebar-resizer-config
BurningTreeC 04b9e5b
different classes for text-editor and bitmap-editor
BurningTreeC fe9825c
no display: none important
BurningTreeC bf07047
assignDomNodeClasses method also for SimpleEngine
BurningTreeC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functions need a dot
.
in the function name. Otherwise thy can only be used with[function[get-preview-state]]
-- For the core we need the possibility to use it with[tf.get-preview-state<something>]
too.That's why I did start with
tf.
prefix eg:tf.function-name-with-hyphens
for TW global functions. If you search the source code fortf.
, you will see some of them in the TW core code already.At the moment they are only used for
$:/tags/Global
functions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the draft pr branch https://github.com/pmario/TiddlyWiki5/blob/toc-v5.3.x-rewrite/core/wiki/macros/toc.tid you can see it used extensively. Otherwise the code would be unreadable. There is some info about the naming schema in code.