MWS: fix a few obvious bugs that typescript caught #8886
Conversation
|
Confirmed: Arlen22 has already signed the Contributor License Agreement (see contributing.md) |
❌ Deploy Preview for tiddlywiki-previews failed.
|
|
@Arlen22 ... Did you see the tests. Some of them fail now. |
|
Oh, I thought they were failing before. I'll double check. |
Arlen22
force-pushed
the
multi-wiki-support
branch
from
10e47d5 to
c7dc21a
Compare
|
Confirmed: Arlen22 has already signed the Contributor License Agreement (see contributing.md) |
|
Ok, yeah, the build is failing with only one change that should not have changed anything. |
|
I've added the other changes back in with slightly better descriptions. |
|
Not sure if I'll change it, but I think these lines are supposed to be |
| @@ -20,7 +20,7 @@ if($tw.node) { | |||
| querystring = require("querystring"), | |||
| crypto = require("crypto"), | |||
| zlib = require("zlib"), | |||
| aclMiddleware = require('$:/plugins/tiddlywiki/multiwikiserver/modules/routes/helpers/acl-middleware.js').middleware; | |||
| aclMiddleware = require('$:/plugins/tiddlywiki/multiwikiserver/routes/helpers/acl-middleware.js').middleware; | |||
There was a problem hiding this comment.
I am sure that this change is wrong. There is no TW title without the modules subdirectory.
There was a problem hiding this comment.
Most plugins, except evernote and text-slicer, leave it out. Core appears to leave it in. I don't have an opinion either way.
| @@ -12,7 +12,7 @@ POST /admin/delete-acl | |||
| /*global $tw: false */ | |||
| "use strict"; | |||
|
|
|||
| var aclMiddleware = require("$:/plugins/tiddlywiki/multiwikiserver/modules/routes/helpers/acl-middleware.js").middleware; | |||
| var aclMiddleware = require("$:/plugins/tiddlywiki/multiwikiserver/routes/helpers/acl-middleware.js").middleware; | |||
| @@ -12,7 +12,7 @@ DELETE /bags/:bag_name/tiddler/:title | |||
| /*global $tw: false */ | |||
| "use strict"; | |||
|
|
|||
| var aclMiddleware = require("$:/plugins/tiddlywiki/multiwikiserver/modules/routes/helpers/acl-middleware.js").middleware; | |||
| var aclMiddleware = require("$:/plugins/tiddlywiki/multiwikiserver/routes/helpers/acl-middleware.js").middleware; | |||
There was a problem hiding this comment.
upstream title is right --- please check all of them
| @@ -44,7 +42,7 @@ function setupStore() { | |||
| return store; | |||
| } | |||
|
|
|||
| function ServerManager(store) { | |||
| function ServerManager() { | |||
There was a problem hiding this comment.
I think removing it, is not right. But @Jermolene there is an inconsistency. Here it says: ServerManager(store) but in line 25 it says:
serverManager: new ServerManager({
store: store
})
Which seems to be an options object.
There was a problem hiding this comment.
The option is not used anywhere. Store is passed in somewhere else, not here.
I was playing around with Typescript support in the multiwikiserver plugin, and it caught a few bugs, so I thought I'd open a PR for them.