Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dark mode #1846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement dark mode #1846

wants to merge 1 commit into from

Conversation

timothytylee
Copy link

Add a Theme parameter for selecting UI theme.

Currently Auto is the same as light theme.

@timothytylee timothytylee mentioned this pull request Oct 13, 2024
Open
CendioOssman
CendioOssman reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Nice work!

There were a few things that still looked a bit odd, have you had a look at these:

  • The selected item in the context menu
  • The icons in popups
  • The green/red colors in the authentication dialog

@CendioOssman
Copy link
Member

A fourth one:

  • the screen selector in the display options

@timothytylee
Implement dark mode
d6438e2 
Add parameter for selecting UI theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CendioOssman CendioOssman CendioOssman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothytylee @CendioOssman