-
Notifications
You must be signed in to change notification settings - Fork 45
[FEATURE] - Get binary release for major platforms #25
Comments
Hi, thanks for the suggestion! It's better to use a container image. I'm going to push it to dockerhub sooner or later. During the build process exporter is linked with with latest libvirt form There's a way to build it with dynamic linking for your distro. There's a So, which is better suite for your case? I can add some CI for this repo to publish distro-specific builds, if it is really useful. But, i thought that the docker image is more popular these days. |
Oh! Actually using your docker image as a base for our build process (Openstack kolla) would be a great idea! |
maybe there is a way to use https://github.com/digitalocean/go-libvirt - as a substitution for libvirt-go ? lib from digital ocean doesn't have C bindings . |
@Ubun1 thanks for pointing that out. Yes, this might be a way to go. But I assume it is a huge rewrite and I'm not sure if it supports all the metrics libvirt-exporter exposes. I'll take a look at it when I have some more free time. |
so, this is the table with mappings between |
@Ubun1 thanks a lot for this! Would you be able to prepare a PR with these changes? |
@AlexZzz @Ubun1 moving to https://github.com/digitalocean/go-libvirt is a great idea! BTW, I've been using https://github.com/zhangjianweibj/prometheus-libvirt-exporter for a while which also makes use of go-libvirt and is yet another implementation of an exporter. It works really well and I was about to start extending it with more info metrics for Nova + OS. But having your (more) widely used libvirt exporter as pure go would just be awesome. Especially when considering the rest of the ecosystem: metric naming, info_metrics, Grafana Dashboards, Prometheus Alerts, ... @Ubun1 - please let me know if you need any help with testing your PR. |
Thanks a lot everyone about this issue, that's really awesome, and yeah, I assume using go-libvirt would be cool but will require a slightly large rewrite as the logics seems not really the same. |
7.0.0-x from fedora 34 repos |
@Ubun1 I am, as stated above (#25 (comment)), really looking forward to this change. Are you still working on this? Could you maybe provide a WiP PR for me to build and test already? |
@frittentheke, sorry, i don't support this project actively anymore, as i don't work on cloud infrastructure:( |
Is your feature request related to a problem? Please describe.
Would it be possible to build binary release for Linux x86_64/aarch64?
Describe the solution you'd like
As for this exporter: https://github.com/openstack-exporter/openstack-exporter/releases
I'd like to be able to download an archive of the statically build exporter for linux.
Describe alternatives you've considered
I'll have to get a two step build phase as our platform is an airgapped platform that can't reach internet and so can't build correctly the exporter without cloning the whole github platform.
Additional context
Any offline platform won't be able to build this exporter as dependencies are refering to github or internet hosted repos.
The text was updated successfully, but these errors were encountered: