Small performance improvements for GeomBuilder._buildCoords #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be shocked if a list comprehension performed any different from a for-loop since they both generate identical C code. |
|
I'll merge. Miniconda is failing us now. I've got a PR that moves us to micromamba. |
sgillies
approved these changes
Nov 10, 2024
sgillies
pushed a commit
that referenced
this pull request
Nov 10, 2024
* Lift ndims check out of loop. * Instantiate list at declaration.
|
Back ported to maint-1.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements to help build coordinate lists a little more efficiently.