Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Tox network profiler #1885

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Implement Tox network profiler #1885

wants to merge 3 commits into from

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Jan 14, 2022 •
edited by iphydf
Loading

This change is Reviewable

@JFreegman JFreegman added the enhancement New feature for the user, not a new feature for build script label Jan 14, 2022
@JFreegman JFreegman added this to the v0.2.x milestone Jan 14, 2022
@restyled-io restyled-io bot mentioned this pull request Jan 14, 2022
Closed
@JFreegman JFreegman force-pushed the netprof branch 11 times, most recently from b93009f to 75fd324 Compare January 14, 2022 20:13
iphydf
iphydf requested changes Jan 14, 2022
View reviewed changes
toxcore/net_profile.c Outdated Show resolved Hide resolved
toxcore/net_profile.c Show resolved Hide resolved
toxcore/net_profile.h Outdated Show resolved Hide resolved
toxcore/net_profile.h Show resolved Hide resolved
toxcore/TCP_client.h Outdated Show resolved Hide resolved
toxcore/tox_private.h Show resolved Hide resolved
toxcore/tox_private.h Outdated Show resolved Hide resolved
@JFreegman JFreegman force-pushed the netprof branch 7 times, most recently from 84ab794 to 687d5b5 Compare January 15, 2022 00:07
@codecov
Copy link

codecov bot commented Jan 15, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.27586% with 165 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (41fb183) to head (f794ffa).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
toxcore/tox_api.c 0.00% 105 Missing ⚠️
toxcore/tox_private.c 57.40% 46 Missing ⚠️
toxcore/TCP_server.c 64.28% 5 Missing ⚠️
toxcore/net_profile.c 92.00% 4 Missing ⚠️
toxcore/TCP_connection.c 84.61% 2 Missing ⚠️
toxcore/net_crypto.c 66.66% 2 Missing ⚠️
toxcore/network.c 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   72.89%   72.48%   -0.42%     
==========================================
  Files         149      150       +1     
  Lines       30570    30874     +304     
==========================================
+ Hits        22285    22379      +94     
- Misses       8285     8495     +210

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iphydf
iphydf approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 19 files at r1, 8 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @JFreegman)

toxcore/tox_private.h, line 60 at r1 (raw file):

Previously, JFreegman wrote…

The reason I named it ZERO is because it has a different purpose depending on the packet type (see the above comment). Any suggestions?

Ok, that's fine then.

@pull-request-attention pull-request-attention bot assigned JFreegman and unassigned iphydf Jan 15, 2022
iphydf
iphydf reviewed Jan 15, 2022
View reviewed changes
Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 19 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @JFreegman)

@JFreegman JFreegman force-pushed the netprof branch 2 times, most recently from 9ee9543 to 38aecfd Compare November 28, 2024 14:00
@pull-request-attention pull-request-attention bot assigned JFreegman and unassigned iphydf Nov 28, 2024
@JFreegman JFreegman force-pushed the netprof branch 2 times, most recently from 8795684 to f794ffa Compare November 28, 2024 15:31
Green-Sky
Green-Sky requested changes Nov 28, 2024
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@JFreegman JFreegman force-pushed the netprof branch 3 times, most recently from 1955d38 to f785959 Compare November 28, 2024 22:49
@JFreegman JFreegman requested a review from Green-Sky December 6, 2024 23:01
@Green-Sky
Copy link
Member

I still want to check toxav and custom packets for friend 2 friend.

@JFreegman
Copy link
Member Author

I still want to check toxav and custom packets for friend 2 friend.

What do you want to check? Both use the same net_crypto packet sending functions as everything else and both use the NET_PACKET_CRYPTO_DATA packet ID. Nothing special happens with either one at the packet recording level. It's easy enough to test via Toxic's netprof branch.

@Green-Sky
Copy link
Member

Green-Sky commented Dec 7, 2024 •
edited
Loading

@JFreegman you are correct, I wrongly assumed this made a difference.

update: here is how a video call looks like
image

Green-Sky
Green-Sky reviewed Dec 16, 2024
View reviewed changes
auto_tests/netprof_test.c
@@ -0,0 +1,121 @@
/** Auto Tests: basic network profile functionality test (UDP only)
* TODO(JFreegman): test TCP packets as well
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this todo still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Green-Sky Green-Sky Green-Sky requested changes

@iphydf iphydf Awaiting requested review from iphydf

@robinlinden robinlinden Awaiting requested review from robinlinden

Requested changes must be addressed to merge this pull request.

Assignees

@JFreegman JFreegman

@robinlinden robinlinden

@iphydf iphydf

Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Milestone
v0.2.21
Development

Successfully merging this pull request may close these issues.
4 participants
@JFreegman @Green-Sky @robinlinden @iphydf