Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Don't expose Tox_System in the public API #2741

Merged
merged 1 commit into from
Mar 17, 2024

Commits on Mar 17, 2024

  1. refactor: Don't expose Tox_System in the public API

    It makes no sense to include it in the public API as clients can't make
    any meaningful use of it via public API, it can only be used if one also
    includes other internal/private headers that we don't install.
    
    It's used only in the testing code, which has access to the internal
    headers.
    
    Fixes #2739, at least to some degree. I decided against moving things to
    a separate `tox_testing.h` and leaving only things in `tox_private.h`
    that we are fine with clients using, as otherwise `tox_lock()` /
    `tox_unlock()` would have to be moved out of `tox_private.h` to
    somewhere else, but `tox_private.h` actually sounds like the right place
    for them, naming-wise. So perhaps it's fine if we have things in
    `tox_private.h` that we don't want clients to use.
    nurupo committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    0ec4978 View commit details
    Browse the repository at this point in the history