Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toxav rtp temp buffer allocation size was too large #2768

Merged
merged 1 commit into from
Sep 17, 2024

fix: toxav rtp temp buffer allocation size was too large

671b1f9
Select commit
Loading
Failed to load commit list.
Merged

fix: toxav rtp temp buffer allocation size was too large #2768

fix: toxav rtp temp buffer allocation size was too large
671b1f9
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Sep 17, 2024 in 1s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : fix: toxav rtp temp buffer allocation size was too large
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : fix: toxav rtp temp buffer allocation size was too large
    and cast from 32bit to 16bit, causing a overflow and making the
    allocated size too small
    Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : and cast from 32bit to 16bit, causing a overflow and making the allocated size too small

supersedes #2766
fixes #2767

info copied from #2767 :

rdata_size here is 16bit, which gets cast from 32bit length, which can be much larger than the max representable of 16bit. BUT, rdata never contains more than a single packet, so why even try to allocate so much...


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}