Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add powerpc case #359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Makefile: add powerpc case

d4d79a9
Select commit
Loading
Failed to load commit list.
Open

Makefile: add powerpc case #359

Makefile: add powerpc case
d4d79a9
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Dec 22, 2024 in 4s

(Semantic release conventions must be followed. ***OR*** Dependabot PRs are exempt from semantic release conventions.) Semantic release conventions must be followed.

Status: FAIL

 Here are some stats of the run:
 3 validations were ran.
 1 PASSED
 2 FAILED

Details

❌ Validator: TITLE

  • (Semantic release conventions must be followed. OR Dependabot PRs are exempt from semantic release conventions.)
    Input : Makefile: add powerpc case
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

❌ Validator: COMMIT

  • Semantic release conventions must be followed.
    Input : Makefile: add powerpc case
    Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : @JFreegman While there are no arch-specific configs at the moment (platforms dir is empty), perhaps add the case of powerpc anyway?

Alternatively, this should also work:

ifeq ($(UNAME_M), "Power Macintosh")
    -include $(CFG_DIR)/platforms/powerpc.mk
endif

(Yes, uname -m returns an awkward value.)


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}