Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty array does not throw error when traversing #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lianqin7
Copy link

@lianqin7 lianqin7 commented Feb 1, 2021

When travers a property in empty array, TypeError would be thrown

const context = {
  foo: {
    bar: []
  }
}


// before
// 'foo.bar.tek.hello' --> [TypeError: Cannot read property 'tek' of undefined]

// after
// 'foo.bar.tek.hello' --> undefined

Copy link

@chetbox chetbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great fix to me and with appropriate tests. 👍🏼 I'm not a maintainer but am commenting in case it's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants