Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Portuguese Language Support #67

Merged
merged 10 commits into from
Oct 19, 2024

Conversation

TomerPacific
Copy link
Owner

@TomerPacific TomerPacific commented Oct 18, 2024

Resolves #66

This pull request includes several changes to improve the localization and refactor the handling of laundry categories in the app. The most important changes involve replacing hardcoded strings with resource references, removing the HowToDoLaundryCategories enum, and updating the layout and text alignment.

Localization Improvements:

  • Added a new strings.xml file for Portuguese translations to support localization. (app/src/main/res/values-pt/strings.xml)

Code Refactoring:

  • Removed the HowToDoLaundryCategories enum and updated the HowToDoLaundryCategory data class to use string resource IDs instead of enum values. (app/src/main/java/com/tomerpacific/laundry/model/HowToDoLaundryCategory.kt)
  • Updated LaundrySymbolsRepository to use string resource IDs for category names instead of HowToDoLaundryCategories enum values. (app/src/main/java/com/tomerpacific/laundry/LaundrySymbolsRepository.kt)
  • Removed unused imports related to the HowToDoLaundryCategories enum. (app/src/main/java/com/tomerpacific/laundry/LaundrySymbolsRepository.kt)

UI Updates:

  • Updated HowToDoLaundryFragment to use string resources for text values and improved text alignment. (app/src/main/java/com/tomerpacific/laundry/fragment/HowToDoLaundryFragment.kt) [1] [2] [3]
  • Updated LaundryCategoriesFragment to use string resources for text values and improved text alignment. (app/src/main/java/com/tomerpacific/laundry/fragment/LaundryCategoriesFragment.kt) [1] [2]

Resource Updates:

  • Added new string resources for various laundry categories and their descriptions. (app/src/main/res/values/strings.xml)

@TomerPacific TomerPacific added enhancement New feature or request dependencies Mo' Libraries Mo' Problems labels Oct 18, 2024
@TomerPacific TomerPacific self-assigned this Oct 18, 2024
@TomerPacific TomerPacific merged commit 26cba5e into master Oct 19, 2024
1 check passed
@TomerPacific TomerPacific deleted the feature/localization-brazil branch October 19, 2024 12:59
This was referenced Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Mo' Libraries Mo' Problems enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add localization to Portuguese 🇵🇹
1 participant