Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix juddering on Android #2

Open
Tommigun1980 opened this issue Jun 15, 2020 · 3 comments
Open

Fix juddering on Android #2

Tommigun1980 opened this issue Jun 15, 2020 · 3 comments
Assignees

Comments

@Tommigun1980
Copy link
Owner

Tommigun1980 commented Jun 15, 2020

Fix juddering when dragging the pane on Androids.

@Tommigun1980 Tommigun1980 self-assigned this Jun 15, 2020
Repository owner deleted a comment from reshnas Aug 15, 2020
@AEZ314
Copy link

AEZ314 commented Dec 6, 2020

Hey solved it yet?

@james937nrg
Copy link

I am having this issue on Android. @Tommigun1980 I might try to fix it... do you have any pointers to help me start?

@JensMig
Copy link

JensMig commented Feb 5, 2022

The problem here is, that in the MessagesPanel_PanUpdate handler in DragView.xaml.cs the panning of the panel is handled via total movement. These numbers are provided by the PanUpdatedEventArgs. At least in the Android emulator these total values mean total values since last event raised, which is more like a delta. So delta is handled twice which leads to the mentioned problem.

If you just take the total value as delta, it works smoothly:

		    case GestureStatus.Running:
                    if (!this.AnimationIsRunning(SwipeAnimationName))
                    {
                        var total = this.IsVertical() ? e.TotalY : e.TotalX;
                        if (!this.IsPositiveGrowthAxis())
                            total = -total;
                        this.PanPanel(total);
                        this.dragPoints.Add(new DragPoint()
                        {
                            total = total,
                            ticks = Stopwatch.GetTimestamp()
                        });
                    }
                    break;

No idea what this means on iOS. Maybe you need a switch here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants