Added listener for when user is done viewing WhatsNew dialog #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonnyL
reviewed
Jul 11, 2019
There was a problem hiding this comment.
Cool. .idea folder should be committed and some commits can be squashed into a single commit.
It will be better if the commit messages follow this emantic Commit Messages Guideline 😄.
|
I squashed some of the commits into a single commit. |
|
I think the |
|
The .idea folder is already included. :) |
|
I don't think so. |
sammyplexus
commented
Jul 19, 2019
Yes |
|
May I please know if I have to do any other thing? :) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through utilizing Kotlin's extension function, it is now possible and optional for clients to add listeners for when users dismiss the dialog view. Additionally, documentation has been updated to reflect the addition.