Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Python 3.12 support #79

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

null8626
Copy link
Member

@null8626 null8626 commented Mar 26, 2024

Fixes #75
Fixes #78

Proposed Changes

  • Add Python 3.12 support by making the aiohttp dependency use versions >=3.9.0. (Update aiohttp constraints #74)
  • Add Python 3.11 support by migrating from setup.py to pyproject.toml.
  • Make the python-publish.yml workflow use PyPI API tokens to publish packages. Since 2024, PyPI requires ALL users to use API tokens to publish new versions of packages, password authentication is now deprecated. Please update the PYPI_PASSWORD workflow secret with your PyPI API token (e.g: pypi-ABCDEF)
  • Deprecate Python 3.6 and 3.7 support, as they have reached their end-of-life.
  • Remove unused StatsWrapper import in the tests/test_autopost.py file.
  • Documentation overhaul.
  • Add malware

@null8626 null8626 changed the title refactor: remove unused import fix: add Python 3.12 support Mar 26, 2024
@null8626
Copy link
Member Author

cc @Esmeray6 @norinorin

@Esmeray6
Copy link
Contributor

Wrong people. :P

@null8626
Copy link
Member Author

Wait what? So the project was handed over to norizon?

@norinorin
Copy link
Contributor

Neither of us maintains this project anymore, or at least I don't. Isn't @editor-syntax the new maintainer?

@null8626
Copy link
Member Author

Ah, i see.

@dev-bun
Copy link

dev-bun commented Mar 26, 2024

Neither of us maintains this project anymore, or at least I don't. Isn't @editor-syntax the new maintainer?

They've left the Discord so I'd assume this package has no active maintainers as of currently

@null8626
Copy link
Member Author

null8626 commented Mar 26, 2024

I can be the current maintainer :D

cc @velddev hmu (just make sure that the pypi token is covered)

@Esmeray6
Copy link
Contributor

cough cough good luck with PRs getting merged cough cough.

@null8626
Copy link
Member Author

If this PR doesn't get merged i'll just make my own fork and force discord.py devs to use THAT :)

.github/workflows/python-package.yml Show resolved Hide resolved
.github/workflows/python-publish.yml Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
null8626 added a commit to Top-gg-Community/rust-sdk that referenced this pull request Mar 27, 2024
@Esmeray6
Copy link
Contributor

Thanks for bringing the recent PyPi change to my attention, @null8626. I don't believe the current GitHub Secrets have the API token set up and the PyPi package is still (yes, after 3 years) owned by me. Veld can contact me on Discord personally (@tothebeat) for the API token or to transfer ownership.

Before any ownership is transferred, I would like direct confirmation from the new maintainer themselves.

@null8626 null8626 mentioned this pull request Jun 6, 2024
@Esmeray6
Copy link
Contributor

If this PR doesn't get merged i'll just make my own fork and force discord.py devs to use THAT :)

Hmm...

@Hadock-is-ok
Copy link

wait, so what's the timeline now? is @null8626 the official maintainer now?

@null8626
Copy link
Member Author

null8626 commented Sep 21, 2024

wait, so what's the timeline now? is @null8626 the official maintainer now?

Yes! I am the new maintainer! The previous maintainers have dropped this project.

At the moment, i'm awaiting Veld to get our PyPI organization up and running since March.

So far, there's no news from him yet as he's probably busy with his life though...

@Hadock-is-ok
Copy link

i see, thanks for updating!

@null8626
Copy link
Member Author

@Esmeray6 @Hadock-is-ok Update as of now...
image

@Hadock-is-ok
Copy link

@Esmeray6 @Hadock-is-ok Update as of now...
image

As expected kek, take your time

@Esmeray6
Copy link
Contributor

Not surprising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Python3.12 compatibility error installing
6 participants