Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: relative images #81

Merged
merged 44 commits into from
May 4, 2024
Merged

feat: relative images #81

merged 44 commits into from
May 4, 2024

Conversation

TorstenDittmann
Copy link
Owner

@TorstenDittmann TorstenDittmann commented Jan 3, 2024 •
edited
Loading

  • automatically importing images via vite that are relative - basically every image path starting with ./ or ../ will be treated like a vite import
  • will break how images are imported by distinguishing between relative images to the route and by the web root

Fixes: #79 #157

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2024 •
edited
Loading

Deploying svelte-markdoc-preprocess with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76e3905
Status: ✅  Deploy successful!
Preview URL: https://e6ce8a3b.svelte-markdoc-preprocess.pages.dev
Branch Preview URL: https://feat-enhanced-image.svelte-markdoc-preprocess.pages.dev

View logs

@TorstenDittmann TorstenDittmann mentioned this pull request Jan 3, 2024
Closed
@TorstenDittmann TorstenDittmann marked this pull request as ready for review January 3, 2024 17:33
@TorstenDittmann
Copy link
Owner Author

@tcmhoang fyi: I plan to finish this PR and make it stable on the weekend because we need it now at @appwrite 😅

I already released another RC 2.0.0-rc.4 with your changes merged.

@TorstenDittmann TorstenDittmann mentioned this pull request May 4, 2024
Closed
@TorstenDittmann TorstenDittmann changed the title feat: enhanced images feat: relative images May 4, 2024
@TorstenDittmann TorstenDittmann merged commit db2fabe into main May 4, 2024
7 checks passed
@TorstenDittmann TorstenDittmann deleted the feat-enhanced-image branch May 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for the official image optimization pkg @sveltejs/enhanced-img
2 participants
@TorstenDittmann @tcmhoang