Discord Integration (Resolves #1833) #2170
Conversation
|
|
| Admin admin = plugin.al.getAdmin(playerSender); | ||
| if (admin.getDiscordID() != null) | ||
| { | ||
| msg("Your Minecraft account is already linked to a Discord account.", ChatColor.RED); |
There was a problem hiding this comment.
What happens in the event you want to over-write your discord ID? I'd be inclined to allow it? OR at the very least we tell people on the command to un-link first?
There was a problem hiding this comment.
Unlink and re-link
There was a problem hiding this comment.
@ZeroEpoch1969 Have players been confused around this before or just tend to get that they need to un-link and re-link?
| else | ||
| { | ||
| Discord.VERIFY_CODES.remove(code); | ||
| FUtil.bcastMsg(playerSender.getName() + " has verified themself!", ChatColor.GOLD); |
There was a problem hiding this comment.
Could we word this something like "Has verified themselves through the Discord verification method" or something like that?
|
CI Pipeline and testing is blocked by #2171 - Looks like an issue with TF-WorldEdit trying to use a super old Craftbukkit version which is no longer resolvable. The issue is fixed more or less with the 7.0.0-Snapshot of WorldEdit but haven't had much joy trying to merge the TF-WorldEdit into that version. As soon as the ticket for the build issues is closed I will put this through the pipeline and do some testing. |
|
I've re-ran the build after getting it working, it appears the dependency required for this PR is missing? It could be an old version or it could be that we don't have a repo with the dependency in. |
| @@ -117,6 +117,13 @@ | |||
| <version>6.1.0-TF</version> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
[ERROR] Failed to execute goal on project totalfreedom: Could not resolve dependencies for project me.totalfreedom:totalfreedom:jar:5.0.2: Failure to find net.dv8tion:JDA:jar:3.8.0_423 in http://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]
Adds the ability to verify via discord account. This code is has been fully tested by me to the fullest extent possible.
Note: The Travis build failed due to the missing JDA dependancy that can be found at https://github.com/DV8FromTheWorld/JDA/releases
Also note: You will need my JDA jar to provide JDA to the server, found at https://github.com/ZeroEpoch1969/Minecraft-JDA/releases
Edit @Wild1145 - Resolves #1833