Use project composition to calculate fees #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmichalis
force-pushed
the
use-project-supply
branch
from
592d716
to
b90d5c1
Compare
Instead of calculating fees at the vintage level we should be calculating fees at the project level. In order to achieve that, use the newly implemented pool function `totalPerProjectTCO2Supply` to determine how many credits of a project are found in a pool.
0xmichalis
force-pushed
the
use-project-supply
branch
from
b90d5c1
to
894b87d
Compare
|
@kosecki123 Would be great to get your review on this before audit. I think Farouq has already agreed to this change in principle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calculating fees at the vintage level
we should be calculating fees at the project
level. In order to achieve that, use the newly
implemented pool function
totalPerProjectTCO2Supplyto determine how many credits of a project are
found in a pool.