feat: create comments #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstebanBorai
reviewed
Sep 9, 2023
crates/server/src/graphql/modules/post/mutation/comment_create.rs
Outdated
Show resolved
Hide resolved
crates/server/src/graphql/modules/post/mutation/comment_create.rs
Outdated
Show resolved
Hide resolved
crates/server/src/graphql/modules/post/mutation/comment_create.rs
Outdated
Show resolved
Hide resolved
crates/server/src/graphql/modules/post/mutation/comment_create.rs
Outdated
Show resolved
Hide resolved
EstebanBorai
reviewed
Sep 9, 2023
crates/server/src/graphql/modules/post/mutation/comment_create.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+36
to
+44
| Err(err) => Ok(Self { | ||
| comment: None, | ||
| error: Some(PostError { | ||
| code: crate::graphql::modules::post::types::PostErrorCode::Unknown, | ||
| message: format!("An error ocurred: {err}"), | ||
| }), | ||
| }), |
There was a problem hiding this comment.
Use err instead of Unknown
There was a problem hiding this comment.
I cannot use error because error no have coincidences with the PostError Type
Michael-Liendo
force-pushed
the
feat/#118-commets-support
branch
from
415f1d9 to
911d79a
Compare
|
By updates this issue is solve in another pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118