Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies and bump version (Target Towny 0.100.4.0+) #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TheFlagCourier
Copy link
Member

Updates POM to better align with Towny 0.100.4.0 (latest stable release)

Properties Changed

  • Bump 'java.version' from 1.16 to 17 (lts)
  • Add 'dynmapapi.version', set to 3.6 and apply to dynmap-api & DynmapCoreAPI
  • Bump 'towny.version' to 0.100.4.0

Dependencies

  • Spigot-API: Bump to 1.20.4 (match Towny)
  • Towny: apply 'towny.version' property (was static)
  • Add DynmapCoreAPI (dynmap-api may not pull this in transient)
  • Bump pl3xmap to 1.20.4-492
  • bump bluemap-api to 2.7.0 (targets Bluemap 5+) [last working jitpack build]
  • Bump squaremap-api to 1.3.2

Build Changes

  • Use 'java.version' property in maven-compiler-plugin target and release settings.
  • Version bumped to '2.2.1' to reflect change in build

Misc. Changes

  • Fix indentation on pom file
  • Add .gitattributes file to supplement .editorconfig

Problems:
- All dependencies and targets were out of date.
- File had mixed-usage of whitespacing, breaking standard.

Changes:
- Bump 'java.version' property to '17' (from '1.16') [Sync w/ Towny 0.100.4.0
- Bump Bukkit API version to '1.19' (from '1.15') [Sync w/ Towny 0.100.4.0]
- Update 'spigot-api' to '1.20.4-R0.1-SNAPSHOT' (from '1.16.5') [Sync w/ Towny 0.100.4.0]
- Bump 'towny.version' property to '0.100.4.0' (from '0.100.2.0')
- Added Property: 'dynmapapi.version', set to '3.6'
- Apply useage of 'towny.version' property for the towny dependency's version.
- Added DynmapCoreAPI (dynmap-api stopped pulling it in as a transient dep)
- Apply	'dynmapapi.version' property to	both 'dynmap-api' and 'DynmapCoreAPI'
- Bump 'pl3xmap' version to '1.20.4-492' (from '1.20.4-476')
- Bump 'bluemap-api' to '2.7.0', targeting Bluemap v5+ (from 'v2.5.1',
  targeting Bluemap v3.14+)
  - Note: Bluemaps no longer builds on Jitpak. Need to migrate on next Towny stable release.
- Bump squaremap-api to '1.3.2' (from '1.1.12')
- Update maven-build-plugin to use the 'java.version' property (was using '1.8')
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, as long as it builds for you. The main class will have to have its mintownyversion field changed to 0.100.4.0.

@TheFlagCourier
Copy link
Member Author

It warns for missing checksums for dynmap-api, DynmapCoreAPI, and pl3xmap but otherwise builds.

@TheFlagCourier TheFlagCourier requested a review from LlmDl November 11, 2024 16:48
@LlmDl LlmDl added this to the 2.2.1 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants