ENG-43804: updating provider for supporting multiple accounts config #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varkey98
requested review from
tim-mwangi,
ryanericson,
t-santoshsahu,
puneet-traceable and
thugrock7
varkey98
commented
May 6, 2024
| github.com/hashicorp/terraform-plugin-docs v0.14.1 | ||
| github.com/hashicorp/terraform-plugin-sdk/v2 v2.17.0 | ||
| github.com/stretchr/testify v1.7.0 | ||
| github.com/aws/aws-sdk-go-v2 v1.26.1 |
There was a problem hiding this comment.
bumped every dependency to latest version, github is flagging vulnerabilities on the current main: https://github.com/Traceableai/terraform-provider-awsapigateway/security/dependabot
tim-mwangi
reviewed
May 6, 2024
| conn := meta.(AwsApiGatewayProvider) | ||
|
|
||
| for _, account := range accounts { | ||
| acc := account.(map[string]interface{}) |
There was a problem hiding this comment.
There's no chance that these type casts would error, right?
There was a problem hiding this comment.
No, if there's a type mismatch, then terraform will throw an error before calling into the provider as its strictly typed there
tim-mwangi
approved these changes
May 6, 2024
t-santoshsahu
approved these changes
May 7, 2024
| api_list = ["api1", "api2"] | ||
| cross_account_role_arn = "" | ||
| exclude = false | ||
| } | ||
| } |
There was a problem hiding this comment.
can add another one for include
There was a problem hiding this comment.
sure, sorry, just merged the pr :|
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.