Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Rename static inputs to variables #503

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor!: Rename static inputs to variables #503

wants to merge 4 commits into from

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Nov 9, 2024 •
edited
Loading

Changes

  • Renamed static inputs context INPUTS to variables VARS over the entire app

  • Include additional migration commands (up/down)

    • Rename workflowdefinition table inputs field to variables
    • Set workflow table static_inputs to variables

    Testing

  • I've tested the migration step manually with a one workflow and a few workflow definitions, where the changes were correctly objserved

@github-actions github-actions bot added breaking Breaking changes engine Improvements or additions to the workflow engine frontend Improvements or additions to the frontend internal Internal changes labels Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topher-lo topher-lo Awaiting requested review from topher-lo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking Breaking changes engine Improvements or additions to the workflow engine frontend Improvements or additions to the frontend internal Internal changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daryllimyt