Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POM and main page tests #19

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
venv
venv

.idea/
__pycache__/
data/__pycache__/
locators/__pycache__/

database_connection.py
3 changes: 2 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ disable=
C0116,
C0115,
E0401,
W0621
W0621,
R0903
Empty file added data/__init__.py
Empty file.
5 changes: 5 additions & 0 deletions data/urls.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@

MAIN_PAGE = "https://www.it-roast.com/#"
LINKEDIN_PAGE = "https://www.linkedin.com/company/train-lab-interns/mycompany/"
REG_PAGE = "https://www.it-roast.com/auth"
GITHUB_PAGE = "https://github.com/Train-lab-intern"
Empty file added locators/__init__.py
Empty file.
11 changes: 11 additions & 0 deletions locators/main_page_locators.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
from selenium.webdriver.common.by import By


class MainPageLocators:
LOGO = (By.CSS_SELECTOR, 'img[alt="Logo"]')
LINKEDIN_LINK = (By.CSS_SELECTOR, "[alt='linkedin']")
GITHUB_LINK = (By.CSS_SELECTOR, "[alt='github']")
ABOUT_US_BUTTON = (By.XPATH, '//*[@id="basic-navbar-nav"]/div[1]/a[1]/button')
TASKS_BUTTON = (By.XPATH, '//*[@id="basic-navbar-nav"]/div[1]/a[2]/button')
REG_BUTTON = (By.CSS_SELECTOR, "[href='/auth']")
TOOLTIP_O_NAS = (By.XPATH, '//*[@id="basic-navbar-nav"]/div[1]/a[1]')
Empty file added pages/__init__.py
Empty file.
30 changes: 30 additions & 0 deletions pages/base_page.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver import ActionChains
from selenium.webdriver.support.wait import WebDriverWait


class BasePage:

def __init__(self, driver, link=None):
self.driver = driver
self.link = link

def open(self):
self.driver.get(self.link)

def hover_over_element(self, locator):
element = self.driver.find_element(*locator)
action = ActionChains(self.driver)
action.move_to_element(element)
action.perform()

def is_element_clickable_after_hover(self, locator, timeout=5):
self.hover_over_element(locator)
return WebDriverWait(self.driver, timeout).until(EC.element_to_be_clickable(locator))

def find_element_and_click(self, locator):
self.driver.find_element(*locator).click()

def assert_current_url(self, expected_url):
current_url = self.driver.current_url
assert current_url == expected_url, f"URL does not match. Actual page is: {current_url}"
22 changes: 22 additions & 0 deletions pages/main_page.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
from pages.base_page import BasePage
from locators.main_page_locators import MainPageLocators
from data.urls import MAIN_PAGE, LINKEDIN_PAGE, GITHUB_PAGE



class MainPage(BasePage):

def open_main_page(self):
self.driver.get(MAIN_PAGE)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А для чего у нас в BasePage существует метод open, если здесь мы отдельным методом реализуем открытие страницы?


def logo_visibility(self):
logo = self.driver.find_element(*MainPageLocators.LOGO)
assert logo.is_displayed()

def check_linkedin_redirection(self):
self.find_element_and_click(MainPageLocators.LINKEDIN_LINK)
self.assert_current_url(LINKEDIN_PAGE)

def check_github_redirection(self):
self.find_element_and_click(MainPageLocators.GITHUB_LINK)
self.assert_current_url(GITHUB_PAGE)
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ PyNaCl==1.5.0
PySocks==1.7.1
pytest==7.4.0
requests==2.31.0
selenium==4.10.0
selenium==4.12.0
sniffio==1.3.0
sortedcontainers==2.4.0
sshtunnel==0.4.0
Expand Down
45 changes: 45 additions & 0 deletions test_main.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import pytest
from pages.main_page import MainPage
from locators.main_page_locators import MainPageLocators


# Header tests
def test_is_logo_visible(driver):
page = MainPage(driver)
page.open_main_page()
page.logo_visibility()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так как это проверка, лучше назвать метод check_logo_is_visible



def test_about_us_clickable(driver):
page = MainPage(driver)
page.open_main_page()
page.hover_over_element(MainPageLocators.ABOUT_US_BUTTON)
page.is_element_clickable_after_hover(MainPageLocators.ABOUT_US_BUTTON)


def test_tasks_button_visible(driver):
page = MainPage(driver)
page.open_main_page()
page.hover_over_element(MainPageLocators.TASKS_BUTTON)
page.is_element_clickable_after_hover(MainPageLocators.ABOUT_US_BUTTON)


def test_enter_clickable(driver):
page = MainPage(driver)
page.open_main_page()
page.hover_over_element(MainPageLocators.REG_BUTTON)
page.is_element_clickable_after_hover(MainPageLocators.REG_BUTTON)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В этих тестах одинаковый код с разными аргументами. Круче всего было бы сделать вместо трех тестов один с разными данными, используя parametrize

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправила это и другие моменты



# Footer tests
@pytest.mark.xfail
def test_linkedin_redirection(driver):
page = MainPage(driver)
page.open_main_page()
page.check_linkedin_redirection()


def test_github_redirection(driver):
page = MainPage(driver)
page.open_main_page()
page.check_github_redirection()