Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed conflicting check #87

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

GabrielCC
Copy link
Contributor

@GabrielCC GabrielCC commented Mar 5, 2024

I'm playing with Treblle and trying to integrate this library.

It seems some work was recently done on the environment check and the current version has 2 pair of checks that contradict themself:

        if (! in_array(\config('app.env'), \explode(',', $treblleConfig['ignored_environments']), true)) {
            return;
        }

this will basically reject all environments, except the ones in the ignored_enviroments

the rest of the check will reject all environments in ignored_environments

fixes #88

@JustSteveKing JustSteveKing merged commit b110d83 into Treblle:master Mar 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current version will fail for any value of app.env
2 participants