Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G4.114 Update validation feedback shown to the user #114

Open
3 tasks
carolyncaron opened this issue Oct 17, 2024 · 0 comments
Open
3 tasks

G4.114 Update validation feedback shown to the user #114

carolyncaron opened this issue Oct 17, 2024 · 0 comments

Comments

@carolyncaron
Copy link
Contributor

carolyncaron commented Oct 17, 2024

Branch

g4.114-updateValidationFeedback

Groups

Group 4 - API | Services | Plugins

Describe

This issue is meant to address the overall design of how validation statuses and messages get relayed back to the user.

This is where the current design is at previous to our current milestone for this module:
image

Design

We (@laceysanderson, @reynoldtan, @ruobinLiu and I) held a meeting to discuss what we'd like to see, both in terms of how it should look for all importers, and specifically the needs of the Traits Importer. These are the things we decided that can begin to be implemented and we can reconvene as needed:

  • Update the feedback "engine" to expect a render array from each feedback item (which may include feedback from 1+ validators)
  • To update the processValidationMessages() method in TraitsImporter to format the messages we want the user to see. We may need to entertain additional methods either in the TraitsImporter class or to the individual validator classes to prevent the code from being too overwhelming
  • We think that continuing to use status icons (representing pass/fail/todo) are helpful and even colour-coding if applicable
@carolyncaron carolyncaron changed the title G4.[issueNo] Update validation feedback shown to the user G4.114 Update validation feedback shown to the user Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant