G4.86 Update Trait Importer formValidate to use new return value style.

[laceysanderson]

Branch

g4.86-updateReturnValue

Groups

Group 2 - Data Importing, Group 4 - API | Services | Plugins

Dependencies

• G4.76 Step 2 --Remove validator TraitImportValues and utilize the 3 newly added validators by the Traits Importer #79
• G4.85 Update Trait Data Validators #85
• G4.92 Update annotation, interface and validator base with new design #92

Describe

This issue is to update the current infrastructure to use the new return values format. This is dependant on Issue #85 being complete.

Design

Task 1

Update the old style validators to return both the old style return value and the new style return value. Do not worry about updating the tests for these validators as they are deprecated. Essentially,

• the title becomes more developer friendly and becomes the case
• the status becomes the valid key with 'fail' becoming FALSE and 'pass' becoming TRUE.
• the items appending into the details string (i.e. failed indices or original values) are instead individual elements in a failedIems array.

Here is the design information for the new return value style:

• 'case': a developer focused string describing the case checked
• 'valid': either TRUE or FALSE depending on if the data is valid or not
• 'failedItems': an array of "items" to be used in the message to the user. This is empty if the data was valid

Task 2

Update the trait importer formValidate to use the new return value style and ignore the old one. Update any import tests with this in mind.

[laceysanderson]

Task 1 is no longer needed due to changes in the timeline. Specifically, we are just getting to this issue much later then expected and the new validators are basically ready so it doesn't make sense to update the old ones.

Task 2 has been moved into issue #90.

As such I'm closing this issue.