Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

g4.85 Update Validators: EmptyCell, ValueInList and DuplicateTraits #106

Merged
merged 35 commits into from
Oct 2, 2024
Merged

g4.85 Update Validators: EmptyCell, ValueInList and DuplicateTraits #106

merged 35 commits into from
Oct 2, 2024

Commits on Sep 4, 2024

  1. Initial commit: Update EmptyCell validator to use getIndices method

    @carolyncaron
    carolyncaron committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    89db728 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Update configureValidators to use setIndices for EmptyCell

    @carolyncaron
    carolyncaron committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    126c72a View commit details
    Browse the repository at this point in the history

  2. Update ValueInList to use validator traits for configuration

    @carolyncaron
    carolyncaron committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5352caf View commit details
    Browse the repository at this point in the history

  3. Fixes breaking tests in testValidatorBaseCheckIndices as it uses Valu… 

    …eInList as the test validator
    @carolyncaron
    carolyncaron committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2a522d1 View commit details
    Browse the repository at this point in the history

  4. Switched checkIndices test to use the fake validator class instead of… 

    … depending on ValueInList validator
    @carolyncaron
    carolyncaron committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3f0b396 View commit details
    Browse the repository at this point in the history

  5. Update DuplicateTraits to use validator traits for configuration

    @carolyncaron
    carolyncaron committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b81290b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge from 4.x including resolved merge conflicts

    @carolyncaron
    carolyncaron committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    42df1e4 View commit details
    Browse the repository at this point in the history

  2. Mocked the logger in TraitImportFormTest to not print log messages (f… 

    …or now)
    @carolyncaron
    carolyncaron committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    becc21e View commit details
    Browse the repository at this point in the history

  3. Update annotation block for the 3 validators to list input type and n… 

    …ot scope
    @carolyncaron
    carolyncaron committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d8120bc View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Split ValidatorFileRowScopeTest into 2 test files, and changed the na… 

    …me of ValidatorTraitImporterTest. This means each of the data-row validators have their own test file
    @carolyncaron
    carolyncaron committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0010c2c View commit details
    Browse the repository at this point in the history

  2. Added a README to the Validators folder in tests to set standards for… 

    … test file naming and placement
    @carolyncaron
    carolyncaron committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0704980 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Updated return value and tests for DuplicateTraits validator

    @carolyncaron
    carolyncaron committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    653968d View commit details
    Browse the repository at this point in the history

  2. Update formValidate tests to work with the newest return array for Du… 

    …plicateTraits
    @carolyncaron
    carolyncaron committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    af3f2fa View commit details
    Browse the repository at this point in the history

  3. Updated return value and tests for EmptyCell validator

    @carolyncaron
    carolyncaron committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1c790c8 View commit details
    Browse the repository at this point in the history

  4. Updated return value and tests for ValueInList validator

    @carolyncaron
    carolyncaron committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7054b21 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Updated the foreach loop that checks for validation failures in the T… 

    …raits Importer
    @carolyncaron
    carolyncaron committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    342b991 View commit details
    Browse the repository at this point in the history

  2. Started updating formValidate in the Trait Importer

    @carolyncaron
    carolyncaron committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5495d35 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Updated validator tests to use AssertSame instead of AssertEquals whe… 

    …re booleans and null are involved.
    @carolyncaron
    carolyncaron committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1f313c6 View commit details
    Browse the repository at this point in the history

  2. Updated Duplicate Trait validator tests to check for all return value… 

    …s (case, valid, failedItems)
    @carolyncaron
    carolyncaron committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e87faab View commit details
    Browse the repository at this point in the history

  3. Created the processValidationMessages method

    @carolyncaron
    carolyncaron committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    aba8edc View commit details
    Browse the repository at this point in the history

  4. Updated the Traits Importer to stop using the array and start using t… 

    …he new method
    @carolyncaron
    carolyncaron committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4046823 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Fixed breaking tests in formValidate

    @carolyncaron
    carolyncaron committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    819c3e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. General cleanup of formValidate() and processValidationMessages()

    @carolyncaron
    carolyncaron committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b71e79c View commit details
    Browse the repository at this point in the history

  2. General cleanup and added documentation to testTraitFormValidation()

    @carolyncaron
    carolyncaron committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3e5035b View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Apply Lacey's suggestions to documentation/comments 

    Co-authored-by: Lacey-Anne Sanderson <las166@mail.usask.ca>
    @carolyncaron @laceysanderson
    carolyncaron and laceysanderson authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fe9a96c View commit details
    Browse the repository at this point in the history

  2. Addressed Lacey's suggestion to add raw_results inside the messages a… 

    …rray for each validator
    @carolyncaron
    carolyncaron committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0abf07f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'g4.85-updateTraitDataValidators' of https://github.com/… 

    …TripalCultivate/TripalCultivate-Phenotypes into g4.85-updateTraitDataValidators
    @carolyncaron
    carolyncaron committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3e4dd8a View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch '4.x' into g4.85-updateTraitDataValidators

    @laceysanderson
    laceysanderson authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e016c1b View commit details
    Browse the repository at this point in the history

  2. Update the GenusConfigured trait to set the genus of the trait servic… 

    …e in the setter.
    @laceysanderson
    laceysanderson committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    630e3db View commit details
    Browse the repository at this point in the history

  3. Merge branch 'g4.85-updateTraitDataValidators' of https://github.com/… 

    …TripalCultivate/TripalCultivate-Phenotypes into g4.85-updateTraitDataValidators
    @laceysanderson
    laceysanderson committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a848d43 View commit details
    Browse the repository at this point in the history

  4. Update configuregenus badly config test to use a data provider and in… 

    …clude the traits service.
    @laceysanderson
    laceysanderson committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5b57cce View commit details
    Browse the repository at this point in the history

  5. Update genus configured trait test to include the traits service.

    @laceysanderson
    laceysanderson committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5b4e637 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Updated/added exception documentation to GenusConfigured trait and Du… 

    …plicateTraits validator
    @carolyncaron
    carolyncaron committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0718ee4 View commit details
    Browse the repository at this point in the history

  2. Moved the single test for a wrong index key given to DuplicateTraits … 

    …into its own test, which now triggers all exception messages
    @carolyncaron
    carolyncaron committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b65a321 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Clarified documentation for the new testIndexKeyExceptions test and i… 

    …ts data provider
    @carolyncaron
    carolyncaron committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e688f14 View commit details
    Browse the repository at this point in the history