Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G4.76 STEP 1 --Divides trait import value plugin instance into 3 separate instances #77

Merged
merged 50 commits into from
Jun 28, 2024
Merged

G4.76 STEP 1 --Divides trait import value plugin instance into 3 separate instances #77

merged 50 commits into from
Jun 28, 2024

Commits on May 10, 2024

  1. Addressed deprecation notices in tests and added testing groups

    @carolyncaron
    carolyncaron committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7b0923a View commit details
    Browse the repository at this point in the history

  2. Renamed new testing groups

    @carolyncaron
    carolyncaron committed May 10, 2024
    Configuration menu
    Copy the full SHA
    07274de View commit details
    Browse the repository at this point in the history

  3. Created new validator EmptyCell with relevant code from TraitImportVa… 

    …lues
    @carolyncaron
    carolyncaron committed May 10, 2024
    Configuration menu
    Copy the full SHA
    084bc07 View commit details
    Browse the repository at this point in the history

  4. Created new validator DuplicateTraits with relevant code from TraitIm… 

    …portValues
    @carolyncaron
    carolyncaron committed May 10, 2024
    Configuration menu
    Copy the full SHA
    834202d View commit details
    Browse the repository at this point in the history

  5. Created new validator TraitTypeColumn with relevant code from TraitIm… 

    …portValues
    @carolyncaron
    carolyncaron committed May 10, 2024
    Configuration menu
    Copy the full SHA
    319e261 View commit details
    Browse the repository at this point in the history

  6. Switch scope from TRAIT IMPORT VALUES to FILE ROW and remove checks f… 

    …or no data rows in the new validators
    @carolyncaron
    carolyncaron committed May 10, 2024
    Configuration menu
    Copy the full SHA
    484ede1 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Set the trait form validate tests to skip, until the new plugins have… 

    … been implemented
    @carolyncaron
    carolyncaron committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f8d6a39 View commit details
    Browse the repository at this point in the history

  2. Created a new test file for validators specific to the file row scope… 

    …, and categorized validator tests into a new directory
    @carolyncaron
    carolyncaron committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b108e52 View commit details
    Browse the repository at this point in the history

  3. Complete setup needed to create plugin instances for testing

    @carolyncaron
    carolyncaron committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0492047 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Removed array type for protected variables in multiple tests since VS… 

    …code was complaining
    @carolyncaron
    carolyncaron committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4efa518 View commit details
    Browse the repository at this point in the history

  2. Created new plugin function validateRow to be used specifically for t… 

    …he file row scope
    @carolyncaron
    carolyncaron committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d14a49e View commit details
    Browse the repository at this point in the history

  3. Completed the validateRow method for EmptyCell validator

    @carolyncaron
    carolyncaron committed May 16, 2024
    Configuration menu
    Copy the full SHA
    293a934 View commit details
    Browse the repository at this point in the history

  4. Added tests for the EmptyCell validator and removed the validate func… 

    …tion
    @carolyncaron
    carolyncaron committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e463f79 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Added 2 error cases to the EmptyCell validator along with tests for them

    @carolyncaron
    carolyncaron committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f75471d View commit details
    Browse the repository at this point in the history

  2. Renamed Trait Type Column validator to more generic Value In List val… 

    …idator
    @carolyncaron
    carolyncaron committed May 17, 2024
    Configuration menu
    Copy the full SHA
    51005cb View commit details
    Browse the repository at this point in the history

  3. Moved indices checking into its own function in the ValidatorBase cla… 

    …ss and created its own Kernel test file
    @carolyncaron
    carolyncaron committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d884e13 View commit details
    Browse the repository at this point in the history

  4. Implemented validateRow() for ValueInList validator

    @carolyncaron
    carolyncaron committed May 17, 2024
    Configuration menu
    Copy the full SHA
    10eaf99 View commit details
    Browse the repository at this point in the history

  5. Fixed ValueInList validator to compare values as case insensitive, an… 

    …d completed 2 tests
    @carolyncaron
    carolyncaron committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8259f29 View commit details
    Browse the repository at this point in the history

  6. Completed tests for ValueInList validator

    @carolyncaron
    carolyncaron committed May 17, 2024
    Configuration menu
    Copy the full SHA
    786927c View commit details
    Browse the repository at this point in the history

  7. Added a check in validateRow for an empty indices array and adjusted … 

    …tests accordingly
    @carolyncaron
    carolyncaron committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0fab283 View commit details
    Browse the repository at this point in the history

  8. Cleaned up the validate function in the ValueInList validator

    @carolyncaron
    carolyncaron committed May 17, 2024
    Configuration menu
    Copy the full SHA
    00017e5 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Started validateRow function for DuplicateTraits validator

    @carolyncaron
    carolyncaron committed May 21, 2024
    Configuration menu
    Copy the full SHA
    aecaf20 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Started processing for DuplicateTraits validator

    @carolyncaron
    carolyncaron committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9803b6e View commit details
    Browse the repository at this point in the history

  2. Redesigned the validateRow method of DuplicateTraits validator

    @carolyncaron
    carolyncaron committed May 22, 2024
    Configuration menu
    Copy the full SHA
    04c5c9c View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Check for existing traits in previous rows, fix error in ValidatorBas… 

    …eTest
    @carolyncaron
    carolyncaron committed May 23, 2024
    Configuration menu
    Copy the full SHA
    131a46e View commit details
    Browse the repository at this point in the history

  2. Created tests for DuplicateTraits validator prior to adding functiona… 

    …lity for checking in the database.
    @carolyncaron
    carolyncaron committed May 23, 2024
    Configuration menu
    Copy the full SHA
    80f1262 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Reorganized tests into generic file row scope tests and trait importe… 

    …r validator tests
    @carolyncaron
    carolyncaron committed May 24, 2024
    Configuration menu
    Copy the full SHA
    acb1d03 View commit details
    Browse the repository at this point in the history

  2. Modified validator test names to be consistent and started a duplicat… 

    …e traits validator test for the database level
    @carolyncaron
    carolyncaron committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d06991f View commit details
    Browse the repository at this point in the history

  3. Added a check in the database for traits to the DuplicateTraits valid… 

    …ator
    @carolyncaron
    carolyncaron committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d1953b0 View commit details
    Browse the repository at this point in the history

  4. Started on final tests for DuplicateTraits validator

    @carolyncaron
    carolyncaron committed May 24, 2024
    Configuration menu
    Copy the full SHA
    cdd787b View commit details
    Browse the repository at this point in the history

  5. Cleaned up the validate function in the DuplicateTraits validator

    @carolyncaron
    carolyncaron committed May 24, 2024
    Configuration menu
    Copy the full SHA
    dca620f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Added todo messages where to pick up after issue #78 is addressed

    @carolyncaron
    carolyncaron committed May 27, 2024
    Configuration menu
    Copy the full SHA
    07acb93 View commit details
    Browse the repository at this point in the history

  2. Slight cleanup and improvement of documentation

    @carolyncaron
    carolyncaron committed May 27, 2024
    Configuration menu
    Copy the full SHA
    27a11b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge remote-tracking branch 'origin/g4.78-fixTraitServiceGetters' in… 

    …to g4.76-divideTraitImportValue
    @carolyncaron
    carolyncaron committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    db415db View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Start testing case 2 of testValidatorDuplicateTraitsDatabase

    @carolyncaron
    carolyncaron committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4b24b25 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/g4.78-fixTraitServiceGetters' in… 

    …to g4.76-divideTraitImportValue
    @carolyncaron
    carolyncaron committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    50bbbc6 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Updated DuplicateTraits validator to use new get trait combo method. … 

    …Tests for validator no longer reuse input data from the previous case
    @carolyncaron
    carolyncaron committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9240c22 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Fixed file-level tests for the DuplicateTraits validator to check for… 

    … case-sensitive trait, method and unit names.
    @carolyncaron
    carolyncaron committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f77ed2c View commit details
    Browse the repository at this point in the history

  2. Cleaned up DuplicateTraits validator, tests almost complete but waiti… 

    …ng on PR 81 to be merged
    @carolyncaron
    carolyncaron committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5f84bf1 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Merge branch '4.x' into g4.76-divideTraitImportValue

    @carolyncaron
    carolyncaron authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4096394 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Finished case #2 test for validator DuplicateTraits at the database l… 

    …evel
    @carolyncaron
    carolyncaron committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    11702d1 View commit details
    Browse the repository at this point in the history

  2. Removed a couple of unused arrays from the Value In List validator test

    @carolyncaron
    carolyncaron committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7151772 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Addressed the source code suggestions from Reynold

    @carolyncaron
    carolyncaron committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ebede3a View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Addressed case 2 by Reynold where whitespace would pass the EmptyCell… 

    … validator
    @carolyncaron
    carolyncaron committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ca00acc View commit details
    Browse the repository at this point in the history

  2. Cleaned up the validator base test

    @carolyncaron
    carolyncaron committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    089f1a8 View commit details
    Browse the repository at this point in the history

  3. Addressed case 4 in Reynolds review where case sentitive checking of … 

    …valid values should be occuring.
    @carolyncaron
    carolyncaron committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9472dde View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Apply suggestions from code review 

    Redeclares protected variables as arrays where it was removed

Co-authored-by: Lacey-Anne Sanderson <las166@mail.usask.ca>
    @carolyncaron @laceysanderson
    carolyncaron and laceysanderson authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    20b0542 View commit details
    Browse the repository at this point in the history

  2. Apply comment suggestions from code review 

    All of Lacey's suggestions within commented parts of the code

Co-authored-by: Lacey-Anne Sanderson <las166@mail.usask.ca>
    @carolyncaron @laceysanderson
    carolyncaron and laceysanderson authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f81c0e2 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Added skip test message

Co-authored-by: Lacey-Anne Sanderson <las166@mail.usask.ca>
    @carolyncaron @laceysanderson
    carolyncaron and laceysanderson authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a76f179 View commit details
    Browse the repository at this point in the history

  4. Updated the duplicate trait validator to check for a duplicate in bot… 

    …h the input file and database
    @carolyncaron
    carolyncaron committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    503879e View commit details
    Browse the repository at this point in the history