avoid hard coding the postgres username #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this. How was this tested? |
|
@yunong can you point me at the lint/style checker? |
|
@davepacheco Tested manually on FreeBSD. If there are tests that need to be run, please let me know where and I will try to run them, though I don't have a complete SDC environment up yet, so if that is required I may not be able to run it. |
|
@swills The test suite and lint/style checkers are run via |
|
Style issues fixed. The tests as far as they can right now, though they hard code the username as well, ironically, so there's more to do. They also hard code some commands, such as zonename, useradd, ctrun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #4
Pull request should be right this time. Thanks!