feat(): fix unary, math, and conditional operatiors + test updates #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
TroyAlford
commented
Oct 5, 2024
TroyAlford
commented
- fully working evaluation of unary/binary/math operators
- clean up a bunch of tests
TroyAlford
commented
Oct 5, 2024
| } | ||
| return undefined | ||
| return handleNaN(binaryResult) |
There was a problem hiding this comment.
this helper ensures that we actually treat NaN as a real value and output its string version when appropriate.
Comment on lines
+143
to
+145
| if (expression.name === 'Infinity') return Infinity | ||
| if (expression.name === '-Infinity') return -Infinity | ||
| if (expression.name === 'NaN') return NaN |
There was a problem hiding this comment.
Infinity, -Infinity, and NaN are valid JS values — but we were throwing them away and incorrectly using them prior.
Comment on lines
+180
to
+183
| const unaryValue = this.#parseExpression( | ||
| expression.argument as AcornJSX.Expression, | ||
| scope, | ||
| ) |
There was a problem hiding this comment.
this is needed in order to handle -Infinity correctly. This value actually comes through as a unary operator - along with the Literal Infinity — but by parsing it, we can get it back as -Infinity correctly.
Hroney
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.