PLUG-106: Fix pending logic

TrueLayer · May 9, 2024 · 6dbbc05 · 6dbbc05
1 parent aa8e223
commit 6dbbc05
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Model/Webapi/Pending.php b/Model/Webapi/Pending.php
@@ -37,7 +37,7 @@ public function checkOrderPlaced(string $token): bool
     {
         try {
             $transaction = $this->transactionRepository->getByPaymentUuid($token);
-            return (bool)$transaction->getOrderId();
+            return $transaction->getStatus() === 'payment_settled';
         } catch (InputException|NoSuchEntityException $e) {
             return false;
         }

diff --git a/Observer/OrderPlacedHandler.php b/Observer/OrderPlacedHandler.php
@@ -25,7 +25,7 @@ class OrderPlacedHandler implements ObserverInterface
      */
     public function __construct(
         OrderRepositoryInterface $orderRepository,
-        LogRepository $logRepository,
+        LogRepository $logRepository
     ) {
         $this->orderRepository = $orderRepository;
         $this->logRepository = $logRepository;