PLUG-96: Fix loss of precision of float to int conversion on payment …

…amounts
TrueLayer · Mar 14, 2024 · e18267e · e18267e
1 parent 7d1eb77
commit e18267e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/.github/workflows/phpstan.yml b/.github/workflows/phpstan.yml
@@ -6,8 +6,8 @@ jobs:
     strategy:
       matrix:
         include:
-          - PHP_VERSION: php81-fpm
-            MAGENTO_VERSION: 2.4.4
+          - PHP_VERSION: php82-fpm
+            MAGENTO_VERSION: 2.4.6
 
     runs-on: ubuntu-latest
     steps:

diff --git a/.github/workflows/setup-di-compile.yml b/.github/workflows/setup-di-compile.yml
@@ -7,12 +7,6 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - PHP_VERSION: php74-fpm
-            MAGENTO_VERSION: 2.4.3-p1
-          - PHP_VERSION: php81-fpm
-            MAGENTO_VERSION: 2.4.4
-          - PHP_VERSION: php81-fpm
-            MAGENTO_VERSION: 2.4.5
           - PHP_VERSION: php82-fpm
             MAGENTO_VERSION: 2.4.6
     runs-on: ubuntu-latest

diff --git a/Service/Order/MakeRequest.php b/Service/Order/MakeRequest.php
@@ -202,15 +202,15 @@ private function getMerchantAccountId(ClientInterface $client, Quote $quote)
 
     /**
      * @param Quote $quote
-     *
+     * @param string $merchantAccountId
      * @return array
      */
     private function prepareData(Quote $quote, string $merchantAccountId): array
     {
         $customerEmail = $quote->getBillingAddress()->getEmail() ?: $quote->getCustomerEmail();
 
         $data = [
-            "amount_in_minor" => (int)bcmul((string)$quote->getBaseGrandTotal(), '100'),
+            "amount_in_minor" => (int) round($quote->getBaseGrandTotal() * 100, 0, PHP_ROUND_HALF_UP),
             "currency" => $quote->getBaseCurrencyCode(),
             "payment_method" => [
                 "provider_selection" => [