chore(EWT-560): Dependency updates and improved reporting for failed acceptance tests #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dili91
changed the title
dili91
force-pushed
the
chores-and-reporting-improvement
branch
from
6584cbf to
1cf0d98
Compare
dili91
commented
May 16, 2024
Comment on lines
+67
to
+68
| - uses: dili91/testvox@v0.1.0 | ||
| name: Generate Slack report from Junit results |
There was a problem hiding this comment.
This is public library/action I've worked on recently. Link
dili91
commented
May 16, 2024
| - name: Acceptance tests in sandbox | ||
| env: | ||
| TL_CLIENT_ID: ${{ secrets.tl_client_id }} | ||
| TL_CLIENT_SECRET: ${{ secrets.tl_client_secret }} | ||
| TL_SIGNING_KEY_ID: ${{ secrets.tl_signing_key_id }} | ||
| TL_SIGNING_PRIVATE_KEY: ${{ secrets.tl_signing_private_key }} | ||
| run: ./gradlew acceptance-tests | ||
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Needed to share artifacts with the reporting job
dili91
commented
May 16, 2024
| @@ -39,7 +39,7 @@ jobs: | |||
| distribution: ${{ matrix.java-distribution }} | |||
| cache: 'gradle' | |||
| - name: Validate Gradle wrapper | |||
| uses: gradle/wrapper-validation-action@v1 | |||
| uses: gradle/actions/wrapper-validation@v3 | |||
There was a problem hiding this comment.
Not raised by Dependabot but there were a few deprecation warnings in our pipelines.
see this
tl-luca-baggi
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps a few dependencies updates, and integrate a new action to build Slack reports for scheduled acceptance tests failures