Better error handling for compile errors #163
Labels
Comments
kevinansfield
added a commit
to kevinansfield/gscan
that referenced
this issue
Apr 16, 2019
refs TryGhost#163 - catch an error from the parse step and push it into the returned messages as a fatal error Invalid file `test.hbs`: ```hbs {{#primary_author}} {{name}} {{/author}} ``` Resulting message: ``` [ { "moduleId": "test.hbs", "message": "primary_author doesn't match author - 1:3", "fatal": true, "column": 3, "line": 1 } ] ```
kevinansfield
added a commit
to kevinansfield/gscan
that referenced
this issue
Jul 25, 2019
refs TryGhost#163 - catch an error from the parse step and push it into the returned messages as a fatal error Invalid file `test.hbs`: ```hbs {{#primary_author}} {{name}} {{/author}} ``` Resulting message: ``` [ { "moduleId": "test.hbs", "message": "primary_author doesn't match author - 1:3", "fatal": true, "column": 3, "line": 1 } ] ```
naz
pushed a commit
to kevinansfield/gscan
that referenced
this issue
Oct 23, 2019
refs TryGhost#163 - catch an error from the parse step and push it into the returned messages as a fatal error Invalid file `test.hbs`: ```hbs {{#primary_author}} {{name}} {{/author}} ``` Resulting message: ``` [ { "moduleId": "test.hbs", "message": "primary_author doesn't match author - 1:3", "fatal": true, "column": 3, "line": 1 } ] ```
naz
pushed a commit
that referenced
this issue
Oct 29, 2019
refs https://github.com/TryGhost/gscan/issues/265 refs #163 - Initial AST linter spike - Add basic handling of parse errors to AST linter - catch an error from the parse step and push it into the returned messages as a fatal error Invalid file `test.hbs`: ```hbs {{#primary_author}} {{name}} {{/author}} ``` Resulting message: ``` [ { "moduleId": "test.hbs", "message": "primary_author doesn't match author - 1:3", "fatal": true, "column": 3, "line": 1 } ] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running into an Handlebars error, GScan doesn't really tell you what went wrong.
GScan renders an error like that:
Which was - in this case - caused by opening with
{{primary_author}}, but closing with{{/author}}. This should be detected and better communicated.The text was updated successfully, but these errors were encountered: