Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS100-NO-UNUSED-CUSTOM-THEME-SETTING ignores /partials directory #523

Open
unitof opened this issue Mar 2, 2024 · 0 comments
Open

GS100-NO-UNUSED-CUSTOM-THEME-SETTING ignores /partials directory #523

unitof opened this issue Mar 2, 2024 · 0 comments

Comments

@unitof
Copy link

unitof commented Mar 2, 2024

The "Custom theme settings defined in package.json must be used at least once in the theme templates" test explicitly ignores them files located in /partials, including /partials/content-cta.hbs.

One of the Ghost Docs examples demonstrates using custom variables to make the CTA text user-editable, but doing so on my theme is now causing it to fail validation because gscan is not seeing the CTA variables used.

Why does gscan ignore partials/*?

Should custom variables related to CTA be used somewhere other than partials/content-cta.hbs and imported?

@unitof unitof changed the title GS100-NO-UNUSED-CUSTOM-THEME-SETTING ignores partials GS100-NO-UNUSED-CUSTOM-THEME-SETTING ignores /partials directory Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant