✨ Added ability to sort by files #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
sort-by-files
branch
5 times, most recently
from
58cfddf
to
9df3bae
Compare
kirrg001
changed the title
kirrg001
force-pushed
the
sort-by-files
branch
2 times, most recently
from
b98afd3
to
e96f066
Compare
refs TryGhost#122 - `gscan.format` now accepts a new option to return a different format - sort by errors & warnings files (sortByFiles: true) - sort by rules by default - it's currently hard to sort the passed rules, because no rule is pushed with the file reference - too much effort for no usage
no issue - failures[..].ref is always the target file reference - ensure consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #122
This PR does not sort the passed rules by files, because we never push the reference and this is too much work now