Fix incorrect "unused custom variables" error #524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nudging for feedback on this. |
|
@sagzy could you take a look at this? Would really help us get rid of the red error box on our admin, for using a custom variable in our CTA partial (an example from Ghost's own documentation). We're on Ghost(Pro) so I can't use a gscan fork. |
cathysarisky
approved these changes
Oct 23, 2024
|
This appears to have been fixed here 404c80f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #523
Proposing this as a quick fix as I don't see why hbs files in
partials/are ignored for this test.See #523 for specific examples.
However open to other approaches if there's a reason
partials/**/*.hbsis ignored!