-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes instrumenting of cron to preserve environment variables. #17
base: master
Are you sure you want to change the base?
Conversation
This changes the startup script to create a crontab with all of the supported environment variables prepended to it to ensure they are available when calling to arkmanager. This fixes an issue where updating and restarting from cron would fail to restart the server properly. This change also includes a number of trailing whitespace trims, as well as an update to the README where the Variables section had a typo for the UPDATEONRESTART entry.
what's your start command of the container |
I just use the default one. Dockerfile has it call user.sh. |
I repushed the Also, worth noting the startup scripts do not have |
Great work :) I saw your issue on Ark Server Tools this weekend but I wasn't available. If you're sure it works, I can merge it right now, but I don't have time to test it before the end of the week. |
ow ow finally turzam show himself :p @krobertson Do you have look at your logs? you don't have different PID now? |
Was going to say wait for the next update to see, but looks like 253.71 came out and our server updated and restarted just fine. |
and nothingin the logs? |
it's our container itself who decide to go fetch the update right? |
This changes the startup script to create a crontab with all of the
supported environment variables prepended to it to ensure they are
available when calling to arkmanager.
This fixes an issue where updating and restarting from cron would fail
to restart the server properly.
This change also includes a number of trailing whitespace trims, as well
as an update to the README where the Variables section had a typo for
the UPDATEONRESTART entry.
Fixes #13 and arkmanager/ark-server-tools#678