Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hold calculation to start / Endposition per Segment #1

Open
Tunnelbliick opened this issue Oct 18, 2023 · 1 comment
Open

Change hold calculation to start / Endposition per Segment #1

Tunnelbliick opened this issue Oct 18, 2023 · 1 comment
Assignees
Labels
Performance Issues that impact performance Priority: High
Milestone

Comments

@Tunnelbliick
Copy link
Owner

Currently each hold is spaced apart by a factor that determins the length, which is used as center point of each hold. This gets the job done but is insanely inefficient, especially with n movement, this becomes very costly to render.

Solution: change the render from Origin center to Bottom enter.
Idea is that we collect the Start and end position of each segment. then rotate that to our desired arrangement. this means that there will be less overlap between sprites, and we can meet re accurately reduce the accuracy of the hold note without it looking shit.

This will require a full rework of the current hold render system.

@Tunnelbliick Tunnelbliick added the Performance Issues that impact performance label Oct 18, 2023
@Tunnelbliick Tunnelbliick self-assigned this Oct 18, 2023
@Tunnelbliick
Copy link
Owner Author

important for v.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Issues that impact performance Priority: High
Projects
None yet
Development

No branches or pull requests

1 participant