Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SB3 Types #18

Open
Tacodiva opened this issue Apr 23, 2023 · 4 comments
Open

SB3 Types #18

Tacodiva opened this issue Apr 23, 2023 · 4 comments

Comments

@Tacodiva
Copy link
Contributor

Tacodiva commented Apr 23, 2023

I'm not sure if these types belong in this or not, because while it's not technically a library, it is used by library in methods like this, but it would be helpful if this library contained types for the project.json object in SB3 files.

If you're happy to add these types, I just wrote some simple ones for my project here that shouldn't be difficult to copy and paste over to here. I will eventually be adding types for each opcode individually to get rid of the records in ProjectSB3BlockBase, but that could be a while.

@GarboMuffin
Copy link
Member

GarboMuffin commented Apr 23, 2023

I don't see any reason why they shouldn't be added

I do wonder if it is possible to convert Scratch's official schemas without too much pain: https://github.com/scratchfoundation/scratch-parser/tree/master/lib

@CrossScarDev
Copy link

When will this be added.

@Tacodiva
Copy link
Contributor Author

Uhmm, I mean with some review from garbo the types I linked in the original issue should be good, they just don't have explicit types for every block. If we wanna wait a few weeks though I can probably provide types for all the vanilla blocks too.

@CrossScarDev
Copy link

Oh thank you. I'm working on a project where these would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants