Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network config property should accept string value #214

Open
drichar opened this issue Aug 12, 2024 · 0 comments
Open

Network config property should accept string value #214

drichar opened this issue Aug 12, 2024 · 0 comments
Labels
feature request New feature or enhancement v4 Issue related to v4.x

Comments

@drichar
Copy link
Collaborator

drichar commented Aug 12, 2024

Reading the network config property from an environment variable requires casting the value to type NetworkId:

const walletManager = new WalletManager({
  wallets: [...],
  network: getNetworkFromEnv() as NetworkId,
})

This should be changed to the less restrictive NetworkId | string with a runtime check to ensure it's valid.

@drichar drichar added feature request New feature or enhancement good first issue Good for newcomers labels Aug 12, 2024
@drichar drichar added v4 Issue related to v4.x and removed good first issue Good for newcomers labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or enhancement v4 Issue related to v4.x
Projects
None yet
Development

No branches or pull requests

1 participant