fix: correct DEBUG log level handling in WalletManager #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor logger initialization in `WalletManager` to correctly handle DEBUG log level - Add `WalletManagerOptions` interface for better type safety - Improve log level determination logic - Export `WalletManagerOptions` from index.ts for external use This commit ensures that the DEBUG log level is properly set and respected, fixing an issue where DEBUG logs were not being output as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the
DEBUGlog level was not being properly handled in theWalletManagerin #264 resulting inDEBUGlogs not being output as expected. It also includes some refactoring and improvements to the logger initialization process.Details
WalletManagerto correctly handle all log levels, includingLogLevel.DEBUGWalletManagerOptionsinterface for improved type safety and clarityWalletManagerOptionsfrom index.ts for external use