Skip to content

Commit

Permalink
updating comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tbuchaillot committed Aug 1, 2023
1 parent 98fdc10 commit 67584a5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion .github/workflows/linter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
go: ${{ matrix.go }}
redis: 5
mongo: 4.2
test-options: "-count=1 -failfast -v"
golangci:
needs: gotest
if: ${{ always() }}
Expand Down
3 changes: 2 additions & 1 deletion pumps/sql_aggregate.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,14 @@ func (c *SQLAggregatePump) Init(conf interface{}) error {
return err
}

// we can run the index creation in background only for postgres since it supports CONCURRENTLY
shouldRunOnBackground := false
if c.dbType == "postgres" {
shouldRunOnBackground = true
c.backgroundIndexCreated = make(chan bool)
}

// if index doesn't exist, create it on background since it's going to migrate all the existing data
// if index doesn't exist, create it
if err := c.ensureIndex(analytics.AggregateSQLTable, shouldRunOnBackground); err != nil {
c.log.Error(err)
return err
Expand Down

0 comments on commit 67584a5

Please sign in to comment.