TT-9228 update regex to blur mongo credentials #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mativm02
approved these changes
Jul 24, 2023
tbuchaillot
approved these changes
Jul 25, 2023
sredxny
deleted the
TT-9228-bugfix/do-not-expose-dns-seed-list-connection
branch
|
/release to release-1.8 |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
(cherry picked from commit 1a6d80b)
|
@sredxny Succesfully merged PR |
buger
added a commit
that referenced
this pull request
Jul 26, 2023
update regex to blur mongo credentials (#686)
tbuchaillot
pushed a commit
that referenced
this pull request
Jul 27, 2023
tbuchaillot
added a commit
that referenced
this pull request
Aug 29, 2023
* fixing SQL Aggregate indexes * TT-9490 change name from APISchema to ApiSchema (#681) * change name from APISchema to ApiSchema * update regex to blur mongo credentials (#686) * updated prometheus to 1.16 (#688) * Auto generated from templates by gromit (#692) Co-authored-by: Gromit <policy@gromit> * [TT-9464] Updating storage to v1.0.7 (#689) * Updating storage to v1.0.7 * go mod tidy * fixing SQL Aggregate indexes * removing unused func * linting * adding waiting time for sqlite * using background only on postgres * adding comment * updating comments * restoring linter.yaml * adding index created on non existing table, not background scenario * adding dbType var from config * taking care of side scenario * controlling bg chan * adding omit_index_creation --------- Co-authored-by: Sredny M <sredny.buitrago@gmail.com> Co-authored-by: Alok G Singh <alephnull@hcoop.net> Co-authored-by: Gromit <policy@gromit> Co-authored-by: Matias <83959431+mativm02@users.noreply.github.com>
tykbot bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
* fixing SQL Aggregate indexes * TT-9490 change name from APISchema to ApiSchema (#681) * change name from APISchema to ApiSchema * update regex to blur mongo credentials (#686) * updated prometheus to 1.16 (#688) * Auto generated from templates by gromit (#692) Co-authored-by: Gromit <policy@gromit> * [TT-9464] Updating storage to v1.0.7 (#689) * Updating storage to v1.0.7 * go mod tidy * fixing SQL Aggregate indexes * removing unused func * linting * adding waiting time for sqlite * using background only on postgres * adding comment * updating comments * restoring linter.yaml * adding index created on non existing table, not background scenario * adding dbType var from config * taking care of side scenario * controlling bg chan * adding omit_index_creation --------- Co-authored-by: Sredny M <sredny.buitrago@gmail.com> Co-authored-by: Alok G Singh <alephnull@hcoop.net> Co-authored-by: Gromit <policy@gromit> Co-authored-by: Matias <83959431+mativm02@users.noreply.github.com> (cherry picked from commit 657436f)
buger
added a commit
that referenced
this pull request
Aug 29, 2023
[TT-9468] New SQL Aggregate indexes (#694) * fixing SQL Aggregate indexes * TT-9490 change name from APISchema to ApiSchema (#681) * change name from APISchema to ApiSchema * update regex to blur mongo credentials (#686) * updated prometheus to 1.16 (#688) * Auto generated from templates by gromit (#692) Co-authored-by: Gromit <policy@gromit> * [TT-9464] Updating storage to v1.0.7 (#689) * Updating storage to v1.0.7 * go mod tidy * fixing SQL Aggregate indexes * removing unused func * linting * adding waiting time for sqlite * using background only on postgres * adding comment * updating comments * restoring linter.yaml * adding index created on non existing table, not background scenario * adding dbType var from config * taking care of side scenario * controlling bg chan * adding omit_index_creation --------- Co-authored-by: Sredny M <sredny.buitrago@gmail.com> Co-authored-by: Alok G Singh <alephnull@hcoop.net> Co-authored-by: Gromit <policy@gromit> Co-authored-by: Matias <83959431+mativm02@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the regex in charge of matching the mongo connection strings, so it receives in the srv format and the blurred is done in the user:pass section
Related Issue
https://tyktech.atlassian.net/browse/TT-9228
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
fork, don't request your
master!masterbranch (left side). Also, you should startyour branch off our latest
master.go mod tidy && go mod vendorgo fmt -sgo vet