-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add track_all_path support for the prometheus pump #714
Conversation
GitHub actions yielded the following error. The command that failed is
This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
GitHub actions yielded the following error. The command that failed is
There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR. This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
Description
This PR addresses the cardinality issue in the Prometheus pump by introducing a new boolean variable called
TrackAllPaths
. TheTrackAllPaths
variable is added to thePrometheusConf
struct inpumps/prometheus.go
. In theWriteData
function, a check forTrackAllPaths
is added before processing each record. IfTrackAllPaths
is true or if the record'sTrackPath
field is true, the record is processed.Summary of Changes
TrackAllPaths
to thePrometheusConf
struct inpumps/prometheus.go
.WriteData
function inpumps/prometheus.go
to include a check forTrackAllPaths
before processing each record.pumps/prometheus_test.go
to validate the behavior of the newTrackAllPaths
variable.Fixes #712.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.