Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tt-6671] AWS Kinesis pump #841

Merged
merged 13 commits into from
Aug 1, 2024
Merged

[tt-6671] AWS Kinesis pump #841

merged 13 commits into from
Aug 1, 2024

Conversation

joshblakeley
Copy link
Member

@joshblakeley joshblakeley commented Jul 3, 2024

Description

This PR adds a Tyk pump for AWS Kinesis pubsub broker.

Example config is simple:

 "kinesis":{
      "type": "kinesis",
      "meta": {
        "stream_name": "tyktest",
        "region": "eu-central-1"
      }
    }

Other fields are batch_size (Default 100 - limit is 500)

Related Issue

https://tyktech.atlassian.net/browse/TT-6671

Motivation and Context

Customer base requirements

How This Has Been Tested

Tested on AWS with Kinesis at load.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

pumps/kinesis.go Outdated Show resolved Hide resolved
pumps/kinesis.go Outdated Show resolved Hide resolved
pumps/kinesis.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mativm02 mativm02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mativm02 mativm02 enabled auto-merge (squash) August 1, 2024 13:15
@mativm02 mativm02 merged commit 25683f2 into master Aug 1, 2024
27 checks passed
@mativm02 mativm02 deleted the tt-6671-kinesis-producer-pump branch August 1, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants