fix(NOJIRA-123): fix Field.properties.fields type #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current type of field.properties.fields is `any[][]` -- I believe it should instead be `any[]` per the example in the API docs:
```
{
"ref": "a_group_field_ref",
"title": "group field",
"type": "group",
"properties": {
"description": "Question group description",
"show_button": true,
"button_text": "Some text",
"fields": [
{
"ref": "nice_readable_website_reference",
"title": "website",
"type": "website",
"properties": {
"description": "Cool description for the website"
}
}
]
},
```
https://developer.typeform.com/create/reference/create-form/
Note, that the actual docs above the example specify the type of `Field.properties.fields` as `array of arrays` but I believe this is an error -- the shape of object above is what I see when in the actual JSON of my form when exported from Typeform.
Thr44
changed the title
mathio
changed the title
mathio
approved these changes
Oct 3, 2023
|
Thank you for the PR. Sorry for the delay 😅 |
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Currently the type of field.properties.fields is
any[][]-- I believe it should instead beany[]per the example in the API docs:https://developer.typeform.com/create/reference/create-form/
Note, that the actual docs above in the link above specify the type of
Field.properties.fieldsasarray of arraybut I believe this is an error -- the shape of the example above is what I see in the actual JSON of my form when exported from Typeform.