Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NOJIRA-123): fix Field.properties.fields type #49

Merged
merged 2 commits into from
Oct 3, 2023

Commits on Nov 7, 2019

  1. fix(types): fix Field.properties.fields type

    Current type of field.properties.fields is `any[][]` -- I believe it should instead be `any[]` per the example in the API docs:
    
    ```
    {
          "ref": "a_group_field_ref",
          "title": "group field",
          "type": "group",
          "properties": {
            "description": "Question group description",
            "show_button": true,
            "button_text": "Some text",
            "fields": [
              {
                "ref": "nice_readable_website_reference",
                "title": "website",
                "type": "website",
                "properties": {
                  "description": "Cool description for the website"
                }
              }
            ]
          },
    ```
    
    https://developer.typeform.com/create/reference/create-form/
    
    Note, that the actual docs above the example specify the type of `Field.properties.fields` as `array of arrays` but I believe this is an error -- the shape of object above is what I see when in the actual JSON of my form when exported from Typeform.
    nicolaslwilson committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    e679ba4 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Configuration menu
    Copy the full SHA
    44463dd View commit details
    Browse the repository at this point in the history