chore(REACH-550): prepare github release workflow #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumpo
reviewed
Jul 4, 2023
.github/workflows/release.yml
Outdated
| - run: yarn test:unit | ||
| - run: (yarn server &) && sleep 1 && yarn test:integration | ||
|
|
||
| - run: yarn build |
There was a problem hiding this comment.
Could we also run everything up to this point on every PR? To avoid unexpected issues when merging.
There was a problem hiding this comment.
You can create a new pr.yml with the same steps but following on:
name: Pull Request
on:
pull_request:
branches:
- main
- beta
There was a problem hiding this comment.
Should be better now! I added if: ${{ contains(github.ref, 'refs/heads/main') || contains(github.ref, 'refs/heads/beta') }}
There was a problem hiding this comment.
Interesting approach. In other projects we have a separate action, but I kind of like this approach - do not repeat yourself! It might be a bit harder to read, but I like it 👍
mathio
approved these changes
Jul 4, 2023
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrate from Travis to Git Hub release workflow.