Actually fixed the popup behavior

Tyrrrz · Aug 23, 2016 · 0987841 · 0987841
1 parent 0cd05e5
commit 0987841
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/OsuHelper/Views/MainWindow.xaml b/OsuHelper/Views/MainWindow.xaml
@@ -331,7 +331,7 @@
                Placement="Left"
                PlacementTarget="{Binding ElementName=BeatmapListDataGrid}"
                PopupAnimation="Fade"
-               StaysOpen="False">
+               StaysOpen="False" Closed="BeatmapInfoPopup_Closed" Opened="BeatmapInfoPopup_Opened">
             <materialDesign:Card HorizontalAlignment="Stretch" VerticalAlignment="Stretch">
                 <Grid HorizontalAlignment="Stretch" VerticalAlignment="Stretch">
                     <Grid.RowDefinitions>

diff --git a/OsuHelper/Views/MainWindow.xaml.cs b/OsuHelper/Views/MainWindow.xaml.cs
@@ -52,16 +52,10 @@ private void MainWindow_OnLocationChanged(object sender, EventArgs e)
 
         private void BeatmapListDataGrid_MouseLeftButtonUp(object sender, MouseEventArgs e)
         {
-            if (BeatmapListDataGrid.SelectedItem == null ||
-                BeatmapListDataGrid.SelectedItem == _lastSelectedPopupRecommendation)
-            {
-                BeatmapInfoPopup.IsOpen = false;
-                _lastSelectedPopupRecommendation = null;
-            }
-            else
+            if (BeatmapListDataGrid.SelectedItem != null &&
+                _lastSelectedPopupRecommendation != BeatmapListDataGrid.SelectedItem)
             {
                 BeatmapInfoPopup.IsOpen = true;
-                _lastSelectedPopupRecommendation = BeatmapListDataGrid.SelectedItem;
             }
         }
 
@@ -74,5 +68,15 @@ private void CalculatorExpectedAccuracySlider_OnPreviewMouseLeftButtonUp(object
         {
             ((Slider) sender).GetBindingExpression(RangeBase.ValueProperty)?.UpdateSource();
         }
+
+        private void BeatmapInfoPopup_Closed(object sender, EventArgs e)
+        {
+            _lastSelectedPopupRecommendation = null;
+        }
+
+        private void BeatmapInfoPopup_Opened(object sender, EventArgs e)
+        {
+            _lastSelectedPopupRecommendation = BeatmapListDataGrid.SelectedItem;
+        }
     }
 }