Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit <br> injection in get_sitename_formatted() #21

Open
cjg89 opened this issue Nov 9, 2017 · 0 comments
Open

Revisit <br> injection in get_sitename_formatted() #21

cjg89 opened this issue Nov 9, 2017 · 0 comments
Assignees
Milestone

Comments

@cjg89
Copy link
Member

cjg89 commented Nov 9, 2017

I think we could potentially re-add the <br> insertion that was removed in the commit below if we tried doing a substring length check on the chunk of the college name after "of".

e.g. for "College of Business", if the portion of the name after "of " ("Business") is greater than a certain number of characters (~15 maybe?), insert the <br>.

It would help us catch college names with longer names that don't have an ampersand, such as "Rosen College of Hospitality Management", but avoid inserting it in cases where the college name is not very long, like "College of Business" and "College of Sciences".

d337e9d

@cjg89 cjg89 added this to the Backlog milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants